Bug 163964

Summary: [CSS Parser] Improvements to selector parsing
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
zalan: review+
Patch zalan: review+

Description Dave Hyatt 2016-10-25 12:29:58 PDT
[CSS Parser] Improvements to selector parsing
Comment 1 Dave Hyatt 2016-10-25 12:44:53 PDT
Created attachment 292803 [details]
Patch
Comment 2 Dave Hyatt 2016-10-25 14:50:43 PDT
Created attachment 292827 [details]
Patch
Comment 3 WebKit Commit Bot 2016-10-25 14:53:02 PDT
Attachment 292827 [details] did not pass style-queue:


ERROR: Source/WebCore/css/parser/CSSParserValues.cpp:413:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/css/CSSSelector.h:250:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dave Hyatt 2016-10-25 16:24:02 PDT
Fixed in r207854.