Bug 163913

Summary:

[CSS Parser] Fix :lang argument parsing

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

CSS

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zalan: review+

Description Dave Hyatt 2016-10-24 14:39:36 PDT

Fix :lang argument parsing to support a list rather than a single identifier.

Comment 1 Dave Hyatt 2016-10-24 14:42:02 PDT

Created attachment 292656 [details]
Patch

Comment 2 Dave Hyatt 2016-10-24 14:54:40 PDT

Landed in r207783.

Comment 3 Ryan Haddad 2016-10-24 17:06:12 PDT

This change appears to have caused fast/selectors/invalid-functional-pseudo-class.html to crash on iOS and macOS:

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r207786%20(10558)/results.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fselectors%2Finvalid-functional-pseudo-class.html

Comment 4 Ryan Haddad 2016-10-24 17:14:29 PDT

Reverted r207783 for reason:

This change appears to have caused fast/selectors/invalid-functional-pseudo-class.html to crash on iOS and macOS

Committed r207790: <http://trac.webkit.org/changeset/207790>