Bug 163871

Summary: [Cocoa] Both modern-media-controls/images/iOS modern-media-controls/images/macOS are installed on both platforms
Product: WebKit Reporter: mitz
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

mitz
Reported 2016-10-23 10:29:36 PDT
The media controls images for both macOS and iOS platforms are installed on both platforms.
Attachments
Patch (2.52 KB, patch)
2017-01-05 07:36 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.52 KB, patch)
2017-01-05 11:39 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-10-23 10:40:23 PDT
<rdar://problem/28908164>
Antoine Quint
Comment 2 2016-10-24 09:14:16 PDT
Mitz, do you know how not to do that?
mitz
Comment 3 2016-10-24 09:24:04 PDT
(In reply to comment #2) > Mitz, do you know how not to do that? Since these are being copied by a script build phase, the script could be changed to exclude the directory for the non-current platform.
Antoine Quint
Comment 4 2017-01-05 07:36:30 PST
Created attachment 298101 [details] Patch
Eric Carlson
Comment 5 2017-01-05 07:57:51 PST
Comment on attachment 298101 [details] Patch You can simplify this by only setting a variable to the platform-specific image directory inside of the "if" blocks, and only having the mkdir and rsync lines once.
Antoine Quint
Comment 6 2017-01-05 11:39:17 PST
Created attachment 298117 [details] Patch for landing
WebKit Commit Bot
Comment 7 2017-01-05 12:16:25 PST
Comment on attachment 298117 [details] Patch for landing Clearing flags on attachment: 298117 Committed r210368: <http://trac.webkit.org/changeset/210368>
WebKit Commit Bot
Comment 8 2017-01-05 12:16:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.