Summary: | Upgrading custom element should enqueue attributeChanged and connected callbacks | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, koivisto, kondapallykalyan, rniwa, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Safari Technology Preview | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 154907 | ||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2016-10-21 22:47:31 PDT
Created attachment 292473 [details]
Fixes the bug
Comment on attachment 292473 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=292473&action=review > Source/WebCore/dom/CustomElementReactionQueue.cpp:218 > + Vector<CustomElementReactionQueueItem> items; > + items.swap(m_items); We could use WTFMove instead of swap. Seems like a clearer idiom: auto items = WTFMove(m_items); Comment on attachment 292473 [details] Fixes the bug Attachment 292473 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2343237 New failing tests: svg/wicd/test-rightsizing-b.xhtml Created attachment 292483 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 292486 [details]
Patch for landing
(In reply to comment #2) > Comment on attachment 292473 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=292473&action=review > > > Source/WebCore/dom/CustomElementReactionQueue.cpp:218 > > + Vector<CustomElementReactionQueueItem> items; > > + items.swap(m_items); > > We could use WTFMove instead of swap. Seems like a clearer idiom: > > auto items = WTFMove(m_items); Done that. Thanks for the review! Comment on attachment 292486 [details] Patch for landing Clearing flags on attachment: 292486 Committed r207710: <http://trac.webkit.org/changeset/207710> All reviewed patches have been landed. Closing bug. |