Bug 16384

Summary: FindSafari /printSafariLauncher incorrectly puts double-quotes around the PATH value
Product: WebKit Reporter: Dimitri Glazkov <dimitri>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial    
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows Vista   
URL: none
Attachments:
Description Flags
Proposed Patch
aroben: review-
Remove double-quotes around PATH value aroben: review+

Dimitri Glazkov
Reported 2007-12-10 12:41:34 PST
FindSafari incorrectly puts double-quotes around the PATH variable value, which makes the path unparseable by the Windows shell. Luckily, this does not seem to affect launching Safari (or debugger), but it does gunk up the environment. Try this: * open Windows shell (cmd.exe) * from webkit nightly directory, launch run-webkit-nightly.cmd * exit WebKit * try launching xcopy -- you will see "'xcopy' is not recognized as an internal..." To remedy, remove double-quotes FindSafari.cpp, line 156
Attachments
Proposed Patch (630 bytes, patch)
2007-12-10 12:50 PST, Dimitri Glazkov 		aroben: review-
DetailsFormatted DiffDiff
Remove double-quotes around PATH value (1.24 KB, patch)
2007-12-10 19:50 PST, Dimitri Glazkov 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov
Comment 1 2007-12-10 12:50:10 PST
Created attachment 17825 [details] Proposed Patch
Adam Roben (:aroben)
Comment 2 2007-12-10 15:45:34 PST
Comment on attachment 17825 [details] Proposed Patch The patch looks good, but we need a ChangeLog entry. See <http://webkit.org/coding/contributing.html> for instructions. Put up a new patch with a ChangeLog and I'll r+ it.
Dimitri Glazkov
Comment 3 2007-12-10 19:50:58 PST
Created attachment 17833 [details] Remove double-quotes around PATH value Per aroben's request, attempted to follow instructions on http://webkit.org/coding/contributing.html
Adam Roben (:aroben)
Comment 4 2007-12-11 09:58:41 PST
Comment on attachment 17833 [details] Remove double-quotes around PATH value r=me Thanks for the patch!
Mark Rowe (bdash)
Comment 5 2007-12-16 17:36:29 PST
Landed in r28789.
Note You need to log in before you can comment on or make changes to this bug.