Bug 163839 – [Cocoa] REGRESSION (r204508): Crash in init_WebCreateFragment when pasting (seen in multiple apps using legacy WebKit)

• Component: HTML Editing
• Status: RESOLVED FIXED

[Darin Adler]

Seeing crashes in init_WebCreateFragment(WebCore::Document&, NSAttributedString*, WebCore::FragmentAndResources&).

Dan pointed out the likely cause:

The use of SOFT_LINK_FRAMEWORK(WebKitLegacy) seems incorrect. The macro is intended for use with frameworks installed directly in /System/Library/Frameworks. But WebKitLegacy is not installed in that location. In macOS it’s installed inside the WebKit umbrella framework, and in iOS it’s installed in /System/Library/PrivateFrameworks.

[Darin Adler]

<rdar://problem/28187870>

[Darin Adler]

I’m going to try this:

#if PLATFORM(IOS)
SOFT_LINK_PRIVATE_FRAMEWORK(WebKitLegacy)
#endif

#if PLATFORM(MAC)
SOFT_LINK_FRAMEWORK_IN_UMBRELLA(WebKit, WebKitLegacy)
#endif

But the real problem is that last time I didn’t test!

[Darin Adler]

Created attachment 292464 [details]
Patch

[Darin Adler]

I’ve uploaded a patch, but also seems critical this time that someone does some testing, ideally me. Maybe I can make a unit test? I am not set up for iOS development at the moment.

Comment on attachment 292464 [details]
Patch

We should have a unit test that exercises this code path. However, such a test would not have caught this mistake, because when we run tests, we always have DYLD_FRAMEWORK_PATH pointing at a location that contains a WebKitLegacy.framework, so dyld never gets as far as to look for it in /System/Library/Frameworks and fail to find it there.

r=me because there’s no practical way to add a regression test for this.

[WebKit Commit Bot]

Comment on attachment 292464 [details]
Patch

Clearing flags on attachment: 292464

Committed r207712: <http://trac.webkit.org/changeset/207712>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.