Bug 163838

Summary:

False success from EWS?

Product:

WebKit

Reporter:

Keith Rollin <krollin>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

ap, cgarcia, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Screenshot of bug 163777	none

Keith Rollin

Reported 2016-10-21 22:14:39 PDT

Created attachment 292462 [details] Screenshot of bug 163777 The attached screenshot shows Bug 163777. At the time I took it, the patch in comment #4 was the most recent one. The EWS status at the top of the window shows that the iOS builds failed while the macOS builds succeeded. I looked at the patch and it seemed like the macOS builds should have failed for the same reasons as the iOS builds. I checked out recent sources (OpenSource r207702), applied patch 292341, and built the result, and it indeed failed as expected. So it's not apparent to me how/why the EWS macOS builds succeeded. Is there something wrong, or do I just not understand the role and operation of EWS?

Attachments
Screenshot of bug 163777 (447.20 KB, image/png) 2016-10-21 22:14 PDT, Keith Rollin	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2016-10-22 19:24:08 PDT

Mac EWS runs on Yosemite, and this code is only enabled on Sierra. The reason why EWS uses Yosemite is that most engineers live on Sierra, and thus testing on Sierra generally makes less sense - engineers already performed it. Ideally, we would test everything, but we don't have such resources.

Note You need to log in before you can comment on or make changes to this bug.