Bug 16383

Summary: Ambiguous Window Usage in kjs_dom.cpp
Product: WebKit Reporter: Rodney Dawes <dobey>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Attachments:
Description Flags
Patch to use KJS::Window instead of just Window ddkilzer: review+

Rodney Dawes
Reported 2007-12-10 11:36:22 PST
Ambiguous usage of Window popping up in kjs_dom.cpp again. This conflicts with the Window type in X11, so we need to namespace it properly with KJS:: here.
Attachments
Patch to use KJS::Window instead of just Window (1.06 KB, patch)
2007-12-10 11:36 PST, Rodney Dawes 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rodney Dawes
Comment 1 2007-12-10 11:36:54 PST
Created attachment 17823 [details] Patch to use KJS::Window instead of just Window
David Kilzer (:ddkilzer)
Comment 2 2007-12-10 19:44:54 PST
Comment on attachment 17823 [details] Patch to use KJS::Window instead of just Window r=me
David Kilzer (:ddkilzer)
Comment 3 2007-12-10 20:52:34 PST
Committed r28606
David Kilzer (:ddkilzer)
Comment 4 2007-12-10 20:55:46 PST
Fixed ChangeLog entry in r28607.
Note You need to log in before you can comment on or make changes to this bug.