Bug 163813

Summary: WebPage should take UserActivity directly for user input
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebKit2Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix andersca: review+

Gavin Barraclough
Reported 2016-10-21 15:01:20 PDT
When we receive mouse/keyboard events in a page, we want to prevent AppNap. We currently do so via the PageThrottler. This patch is to just make the WebPage drive the UserActivity directly. Two reasons to do so: (1) to cleanup & simplify for further refactoring. (2) The current code isn't really achieving the desired effect. The page setting the flag in the throttler to get the activity to be set is now a less effective way of achieving this goal, since the PageActivityState bounces back across to the UI process & then messages back to the WebContent process to take the UserActivity. These extra hops defeat the purpose of making sure the boost from the initial message isn't lost.
Attachments
Fix (8.59 KB, patch)
2016-10-21 15:05 PDT, Gavin Barraclough 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2016-10-21 15:05:57 PDT
Created attachment 292418 [details] Fix
Gavin Barraclough
Comment 2 2016-10-21 16:23:03 PDT
Committed revision 207699.
Note You need to log in before you can comment on or make changes to this bug.