Implement Icon for Gtk

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Christian Dywan]

When looking at the "file" control I noticed that the class Icon that is used to display a file icon is not implemented.

[Christian Dywan]

Created attachment 17818 [details]
Implement Icon for Gtk

This implementation creates a GdkPixbuf for the icon and probes the icon theme for an appropriate icon according to the icon naming specification or to gnome's icon names respectively.

[Alp Toker]

Comment on attachment 17818 [details]
Implement Icon for Gtk

I didn't check the icon name code yet, but the drawing should almost certainly be done with cairo and gdk_cairo_set_source_pixbuf() rather than gdk_draw_pixbuf() so that the drawing operation will integrate with the rest of the graphics backend.

A ChangeLog, particularly to explain lookupIconName() (which was non-obvious to me) would be helpful.

Thanks!

[Christian Dywan]

Created attachment 17843 [details]
Use cairo, with Changelog and explanation

[Alp Toker]

What site or test case can this patch be checked against?

[Christian Dywan]

Created attachment 17962 [details]
Updated patch

You can test the code by navigating to any website containing a "file" control. As soon as a file is chosen, an icon is displayed near the filename.

[Alp Toker]

Comment on attachment 17962 [details]
Updated patch

r=me

Will add the save/restore, m_icon initialization and style cleanups before landing.

[Alp Toker]

Landed in r28809.