Bug 163763

Summary: AX: VoiceOver is not detecting ARIA treeview if it contains role="presentation"
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch none

Description Nan Wang 2016-10-20 15:38:57 PDT
VoiceOver does not recognise a tree if there are elements with role=“presentation” in the structure.

<rdar://problem/28280231>
Comment 1 Nan Wang 2016-10-20 15:48:38 PDT
Created attachment 292273 [details]
patch
Comment 2 chris fleizach 2016-10-20 15:55:55 PDT
Comment on attachment 292273 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292273&action=review

> Source/WebCore/accessibility/AccessibilityTree.cpp:100
> +            if (!nodeHasTreeItemChild(*child))

does this only work one level deep then?
Comment 3 Nan Wang 2016-10-20 16:02:45 PDT
Comment on attachment 292273 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292273&action=review

>> Source/WebCore/accessibility/AccessibilityTree.cpp:100
>> +            if (!nodeHasTreeItemChild(*child))
> 
> does this only work one level deep then?

Yes. I think normally web author will just have this one level. Do you think we should cover multiple level case?
Comment 4 WebKit Commit Bot 2016-10-20 18:18:06 PDT
Comment on attachment 292273 [details]
patch

Clearing flags on attachment: 292273

Committed r207647: <http://trac.webkit.org/changeset/207647>
Comment 5 WebKit Commit Bot 2016-10-20 18:18:10 PDT
All reviewed patches have been landed.  Closing bug.