Bug 163745

Summary: Improve error message when passing a null ArrayBuffer to bufferData()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dino, esprehn+autocc, graouts, gyuyoung.kim, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Myles C. Maxfield
Reported 2016-10-20 11:39:06 PDT
Improve error message when passing a null ArrayBuffer to bufferData()
Attachments
Patch (9.28 KB, patch)
2016-10-20 11:40 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-10-20 11:40:18 PDT
Created attachment 292230 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-20 12:19:51 PDT
Comment on attachment 292230 [details] Patch Clearing flags on attachment: 292230 Committed r207632: <http://trac.webkit.org/changeset/207632>
WebKit Commit Bot
Comment 3 2016-10-20 12:19:57 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2016-10-20 18:11:30 PDT
Is this the right way to go about this? Can we make the generated bindings generate good error messages instead of hand writing null checking code just to increase the quality of the messages?
Note You need to log in before you can comment on or make changes to this bug.