Bug 163734

Summary:

GC should scan stack at the end

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

149432

Attachments:

Description	Flags
the patch	mark.lam: review+
the patch	none
possibly better patch	none
the patch	none
possibly better patch	mark.lam: review+
patch for landing	none

Description Filip Pizlo 2016-10-20 08:58:22 PDT

Because we will have a grey stack GC.

Comment 1 Filip Pizlo 2016-11-04 13:05:50 PDT

Created attachment 293917 [details]
the patch

Comment 2 Mark Lam 2016-11-04 13:31:28 PDT

Comment on attachment 293917 [details]
the patch

r=me.  Looks reasonable to me.

Comment 3 Filip Pizlo 2016-11-04 13:39:52 PDT

Created attachment 293920 [details]
the patch

Comment 4 Filip Pizlo 2016-11-04 13:40:17 PDT

Created attachment 293921 [details]
possibly better patch

Comment 5 Filip Pizlo 2016-11-04 13:40:41 PDT

(In reply to comment #2)
> Comment on attachment 293917 [details]
> the patch
> 
> r=me.  Looks reasonable to me.

Sorry, it was broken. :-(  There's something subtle about CodeBlock marking, I'm still investigating the best approach.

Comment 6 Filip Pizlo 2016-11-04 14:20:40 PDT

Created attachment 293927 [details]
the patch

Comment 7 Filip Pizlo 2016-11-04 14:24:25 PDT

Created attachment 293928 [details]
possibly better patch

Still experimenting.

Comment 8 Mark Lam 2016-11-04 15:30:41 PDT

Comment on attachment 293928 [details]
possibly better patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293928&action=review

r=me.  Looks good to me.

> Source/JavaScriptCore/ChangeLog:18
> +        This change should not change performance or behavior. I'm still testing it.

Please replace "I'm still testing it." with test results when done if all is well.

Comment 9 Filip Pizlo 2016-11-04 15:31:31 PDT

(In reply to comment #8)
> Comment on attachment 293928 [details]
> possibly better patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=293928&action=review
> 
> r=me.  Looks good to me.
> 
> > Source/JavaScriptCore/ChangeLog:18
> > +        This change should not change performance or behavior. I'm still testing it.
> 
> Please replace "I'm still testing it." with test results when done if all is
> well.

Right!  Will do!

Comment 10 Filip Pizlo 2016-11-04 16:07:55 PDT

Created attachment 293949 [details]
patch for landing

Still testing it.

Comment 11 Filip Pizlo 2016-11-04 20:51:00 PDT

OK, this is perf-neutral.

Comment 12 Filip Pizlo 2016-11-09 20:27:52 PST


*** This bug has been marked as a duplicate of bug 164454 ***