Bug 163728

Summary: [Modern Media Controls] Media Controller: fullscreen toggle support
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 10   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=164314
Attachments:
Description Flags
Patch
none
Patch none

Antoine Quint
Reported 2016-10-20 07:40:06 PDT
We need to enter fullscreen when the fullscreen control in the controls bar is clicked.
Attachments
Patch (26.72 KB, patch)
2016-10-20 07:42 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (15.37 KB, patch)
2016-11-02 02:37 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2016-10-20 07:40:18 PDT
<rdar://problem/27989486>
Antoine Quint
Comment 2 2016-10-20 07:42:12 PDT
Created attachment 292184 [details] Patch
Antoine Quint
Comment 3 2016-10-20 07:50:33 PDT
Tests aren't ready yet but the source can be reviewed already.
Antoine Quint
Comment 4 2016-11-02 02:37:25 PDT
Created attachment 293649 [details] Patch
Antoine Quint
Comment 5 2016-11-02 02:47:02 PDT
One of the new tests is skipped on iOS due to eventSender usage, this is tracked by https://bugs.webkit.org/show_bug.cgi?id=164314.
WebKit Commit Bot
Comment 6 2016-11-02 03:50:41 PDT
Comment on attachment 293649 [details] Patch Clearing flags on attachment: 293649 Committed r208274: <http://trac.webkit.org/changeset/208274>
WebKit Commit Bot
Comment 7 2016-11-02 03:50:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.