Bug 163714

Summary: [JSC] throw TypeError when constructing dynamically created JSGeneratorFunction
Product: WebKit Reporter: Caitlin Potter (:caitp) <caitp>
Component: New BugsAssignee: Caitlin Potter (:caitp) <caitp>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Caitlin Potter (:caitp) 2016-10-19 18:22:16 PDT 
[JSC] throw TypeError when constructing dynamically created JSGeneratorFunction
Comment 1 Caitlin Potter (:caitp) 2016-10-19 18:25:29 PDT 
Created attachment 292139 [details]
Patch
Comment 2 Caitlin Potter (:caitp) 2016-10-19 18:27:24 PDT 
PTAL, another blocker causing test failures in the runtime patch for async functions. Corrects a little spec violation that is missing test coverage
Comment 3 Mark Lam 2016-10-19 20:00:30 PDT 
Comment on attachment 292139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292139&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        According to CreateDynamicFunction() (https://tc39.github.io/ecma262/#sec-createdynamicfunction), non
> +        "normal functions are not constructors. Previously, dynamically created functions

typo: /non"normal/non-normal/.
Comment 4 Caitlin Potter (:caitp) 2016-10-20 07:38:37 PDT 
Created attachment 292182 [details]
Patch
Comment 5 WebKit Commit Bot 2016-10-20 07:39:51 PDT 
Comment on attachment 292182 [details]
Patch

Rejecting attachment 292182 [details] from review queue.

caitp@igalia.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 6 WebKit Commit Bot 2016-10-20 08:03:27 PDT 
Comment on attachment 292182 [details]
Patch

Clearing flags on attachment: 292182

Committed r207618: <http://trac.webkit.org/changeset/207618>
Comment 7 WebKit Commit Bot 2016-10-20 08:03:30 PDT 
All reviewed patches have been landed.  Closing bug.