Bug 16371 – Implement additional mouse cursors for Gtk

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Christian Dywan]

There are several mouse cursors missing, ie. currently a default pointer is used for all unsupported cursors. The missing cursors that are not guaranteed to be available should have hardcoded defaults and allow for custom themed replacements.

[Christian Dywan]

Created attachment 17810 [details]
Initial patch with several new cursors

This patch implements vertical-text, context-menu, copy, alias, zoom-in and zoom-out. These names are overridable by cursor themes.

The hardcoded cursor images are taken from [1], so I added the original author to the copyright line. I hope that is appropriate.

[1] http://lxr.mozilla.org/mozilla1.8/source/widget/src/gtk2/nsGtkCursors.h?raw=1

[Christian Dywan]

Created attachment 17817 [details]
Updated, using enums, a struct and correct hotspots now

[Alp Toker]

Comment on attachment 17817 [details]
Updated, using enums, a struct and correct hotspots now

>-// FIXME: should find better GDK cursors for those than a generic GDK_LEFT_PTR
>+static GdkCursor* custom_cursor_new(CustomCursorType cursorType)

That can just be a TODO rather than a FIXME. The function should have a camelCase name since this is WebCore code. (The names of the moz_ variables don't matter so much, you can leave them as-is.)

>+
> const Cursor& verticalTextCursor()
> {
>-    return pointerCursor();
>+    static Cursor c = custom_cursor_new(CustomCursorVerticalText);
> }

This function is missing a 'return c;'

Could you write a ChangeLog entry, including a mention of where the code was borrowed from?

Thanks!

[Christian Dywan]

Created attachment 17842 [details]
Updated with ChangeLog

[Alp Toker]

Comment on attachment 17842 [details]
Updated with ChangeLog

r=me 

Will remove the GLib use from the header file, remove the deprecated unref calls, fix a minor formatting issue (space missing in if statement), and constify fg and bg before landing.

Thanks!

[Alp Toker]

Landed in r28613.