Bug 163675

Summary:

Revert r207151

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2016-10-19 11:37:56 PDT

Revert r207151

Attachments
Patch (184.61 KB, patch) 2016-10-19 11:40 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (184.75 KB, patch) 2016-10-19 15:09 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (189.41 KB, patch) 2016-10-19 15:49 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (144.37 KB, patch) 2016-10-19 22:30 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2016-10-19 11:40:32 PDT

Created attachment 292087 [details] Patch

WebKit Commit Bot

Comment 2 2016-10-19 11:42:55 PDT

Attachment 292087 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/mac/CookieJarMac.mm:40: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/platform/network/cocoa/CredentialCocoa.mm:89: Missing spaces around : [whitespace/init] [4] ERROR: Tools/DumpRenderTree/config.h:0: Use #pragma once header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/ProtectionSpace.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ResourceRequestCFNet.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:109: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:113: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:119: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:125: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:131: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:139: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:144: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:150: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:162: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:58: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:58: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebDownload.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/WebCorePrefix.h:0: Use #pragma once header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Tools/DumpRenderTree/DumpRenderTree.h:29: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/mac/Misc/WebDownloadInternal.h:0: Use #pragma once header guard. [build/header_guard] [5] ERROR: Source/WebKit/mac/Misc/WebDownloadInternal.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownloadInternal.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownloadInternal.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/mac/FormDataStreamMac.h:29: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/mac/FormDataStreamMac.h:43: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/win/WebURLResponse.h:0: Use #pragma once header guard. [build/header_guard] [5] ERROR: Source/WebCore/testing/js/WebCoreTestSupportPrefix.h:0: Use #pragma once header guard. [build/header_guard] [5] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:67: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:236: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:240: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/win/WebCoreSupport/WebFrameNetworkingContext.h:25: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/AuthenticationChallenge.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/win/WebError.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cocoa/CredentialCocoa.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 62 in 118 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 3 2016-10-19 15:09:46 PDT

Created attachment 292118 [details] Patch

WebKit Commit Bot

Comment 4 2016-10-19 15:11:11 PDT

Attachment 292118 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/mac/CookieJarMac.mm:40: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/platform/network/cocoa/CredentialCocoa.mm:89: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/ProtectionSpace.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ResourceRequestCFNet.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:109: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:113: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:119: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:125: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:131: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:139: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:144: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:150: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:162: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:58: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:58: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebDownload.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Tools/DumpRenderTree/DumpRenderTree.h:29: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/mac/Misc/WebDownloadInternal.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownloadInternal.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownloadInternal.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/mac/FormDataStreamMac.h:29: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/mac/FormDataStreamMac.h:43: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:67: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:236: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:240: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/win/WebCoreSupport/WebFrameNetworkingContext.h:25: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/AuthenticationChallenge.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/win/WebError.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cocoa/CredentialCocoa.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 57 in 118 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 5 2016-10-19 15:49:47 PDT

Created attachment 292122 [details] Patch

WebKit Commit Bot

Comment 6 2016-10-19 15:51:27 PDT

Attachment 292122 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/mac/CookieJarMac.mm:40: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/platform/network/cocoa/CredentialCocoa.mm:89: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/ProtectionSpace.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ResourceRequestCFNet.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:109: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:113: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:119: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:125: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:131: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:139: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:144: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:150: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/mac/ResourceErrorMac.mm:162: Extra space for operator ++; [whitespace/operators] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:57: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:58: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:58: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:60: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:63: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:64: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/win/WebDownload.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Tools/DumpRenderTree/DumpRenderTree.h:29: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/mac/Misc/WebDownloadInternal.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownloadInternal.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownloadInternal.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/mac/FormDataStreamMac.h:29: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/mac/FormDataStreamMac.h:43: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:67: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:236: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebDownload.mm:240: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/win/WebCoreSupport/WebFrameNetworkingContext.h:25: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/AuthenticationChallenge.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/win/WebError.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/network/cocoa/CredentialCocoa.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 57 in 120 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brent Fulgham

Comment 7 2016-10-19 17:38:05 PDT

Comment on attachment 292122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292122&action=review This revision seems okay, though I'm a little surprised the rename from CFNETWORK->CFURLCONNECTION had to be rolled out, too. > Source/WTF/wtf/Platform.h:595 > +#define USE_CFNETWORK 1 Do you really want to undo the change from "USE_CFNETWORK" to "USE_CFURLCONNECTION"?

Alex Christensen

Comment 8 2016-10-19 22:30:55 PDT

Created attachment 292151 [details] Patch

WebKit Commit Bot

Comment 9 2016-10-19 22:32:20 PDT

Attachment 292151 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/CredentialCocoa.mm:89: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:48: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:50: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:50: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/platform/network/mac/CookieJarMac.mm:40: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 6 in 82 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 10 2016-10-19 23:08:24 PDT

https://trac.webkit.org/changeset/207585

Note You need to log in before you can comment on or make changes to this bug.