Summary: | REGRESSION (r207480): 3 Dromaeo tests failing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | New Bugs | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, fpizlo, hyatt, ysuzuki | ||||||
Priority: | P2 | ||||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ryan Haddad
2016-10-18 17:10:29 PDT
This seems pretty urgent. May be related to https://trac.webkit.org/changeset/207479? (In reply to comment #2) > May be related to https://trac.webkit.org/changeset/207479? Looks like the most suspicious indeed. It'd be good to see a crash trace to confirm. I tried to reproduce locally but it does not crash for me :/ Crashlogs on the bot point to https://trac.webkit.org/changeset/207480 Thread 17 Crashed:: WTF::AutomaticThread 0 com.apple.JavaScriptCore 0x000000010a411159 0x10988c000 + 12079449 1 com.apple.JavaScriptCore 0x000000010a3f90a4 bool WTF::ConditionBase::waitForSecondsImpl<WTF::Lock>(WTF::Lock&, double) + 340 (Condition.h:74) 2 com.apple.JavaScriptCore 0x000000010a420db8 std::__1::__function::__func<WTF::AutomaticThread::start(WTF::Locker<WTF::LockBase> const&)::$_0, std::__1::allocator<WTF::AutomaticThread::start(WTF::Locker<WTF::LockBase> const&)::$_0>, void ()>::operator()() + 232 (AutomaticThread.cpp:133) 3 com.apple.JavaScriptCore 0x000000010a425f72 WTF::threadEntryPoint(void*) + 178 (Threading.cpp:61) 4 com.apple.JavaScriptCore 0x000000010a42638f WTF::wtfThreadEntryPoint(void*) + 15 (ThreadingPthreads.cpp:166) 5 libsystem_pthread.dylib 0x00007fff8b83799d _pthread_body + 131 6 libsystem_pthread.dylib 0x00007fff8b83791a _pthread_start + 168 7 libsystem_pthread.dylib 0x00007fff8b835351 thread_start + 13 Created attachment 292114 [details]
Crashlog
Looks like that change may also be causing flaky crashes during LayoutTests: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r207566%20(699)/results.html (In reply to comment #6) > Looks like that change may also be causing flaky crashes during LayoutTests: > > https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/ > r207566%20(699)/results.html Looking. Created attachment 292120 [details]
the patch
Comment on attachment 292120 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=292120&action=review > Source/WTF/wtf/ParkingLot.cpp:708 > - > + Reverted. Comment on attachment 292120 [details]
the patch
r=me if EWS complaints are not relevanl.
(In reply to comment #10) > Comment on attachment 292120 [details] > the patch > > r=me if EWS complaints are not relevanl. Thanks, I will run tests locally to be sure. Landed in https://trac.webkit.org/changeset/207577. Lets hope that's it. |