Bug 163591

Summary:

[GTK] Cannot build GTK+ with CUPS 2.* versions

Product:

WebKit

Reporter:

Manuel Rego Casasnovas <rego>

Component:

WebKitGTK

Assignee:

Manuel Rego Casasnovas <rego>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bugs-noreply, cgarcia, changseok, commit-queue, fred.wang, jdiggs, mcatanzaro, mrobinson, pnormand

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

163689, 163776

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch to workaround the build	none
Patch	none

Manuel Rego Casasnovas

Reported 2016-10-18 01:29:56 PDT

[GTK] Cannot build GTK+ with CUPS 2.* versions

Attachments
Patch (1.35 KB, patch) 2016-10-18 01:32 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (3.32 KB, patch) 2016-10-19 13:16 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch to workaround the build (604 bytes, patch) 2016-10-27 03:20 PDT, Xabier Rodríguez Calvar	no flags	Details Formatted Diff Diff
Patch (2.80 KB, patch) 2016-12-07 10:14 PST, ChangSeok Oh	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Manuel Rego Casasnovas

Comment 1 2016-10-18 01:31:12 PDT

GTK+ is wrongly checking about the avaible CUPS version, so if you have CUPS 2.* the configure step fails. The issue has already been fixed in GTK+ upstream: https://git.gnome.org/browse/gtk+/commit/id=631f6b536485829a0bd00532f5826ad302b4951b But the change is not part of the 3.16.* versions.

Manuel Rego Casasnovas

Comment 2 2016-10-18 01:32:35 PDT

Created attachment 291930 [details] Patch

Carlos Garcia Campos

Comment 3 2016-10-18 01:35:23 PDT

Comment on attachment 291930 [details] Patch Have you checked that printing tests still work with cups disabled? I would add a patch for gtk+ with the upstream fix, at least until we bump the GTK+ version in jhbuild.

Manuel Rego Casasnovas

Comment 4 2016-10-18 01:41:26 PDT

Ok, I can add the patch if you prefer it. Thanks for the quick reviews! (In reply to comment #1) > The issue has already been fixed in GTK+ upstream: > https://git.gnome.org/browse/gtk+/commit/ > id=631f6b536485829a0bd00532f5826ad302b4951b Sorry this link was wrong, the right one is: https://git.gnome.org/browse/gtk+/commit/?id=631f6b536485829a0bd00532f5826ad302b4951b

Michael Catanzaro

Comment 5 2016-10-18 06:50:21 PDT

Comment on attachment 291930 [details] Patch I agree with Carlos, this doesn't look like a good idea.

Manuel Rego Casasnovas

Comment 6 2016-10-19 13:16:25 PDT

Created attachment 292102 [details] Patch This is the version using the upstream patch to fix the build with CUPS. However it doesn't work if glib is not in version 2.50. So I've provided a different patch in bug #163689 to bump the glib version that should be landed before this one.

WebKit Commit Bot

Comment 7 2016-10-20 03:13:46 PDT

Comment on attachment 292102 [details] Patch Clearing flags on attachment: 292102 Committed r207609: <http://trac.webkit.org/changeset/207609>

WebKit Commit Bot

Comment 8 2016-10-20 03:13:51 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 9 2016-10-21 01:17:48 PDT

Re-opened since this is blocked by bug 163776

Manuel Rego Casasnovas

Comment 10 2016-10-21 14:37:14 PDT

(In reply to comment #3) > Have you checked that printing tests still work with cups disabled? FWIW, I've verified that TestWebKitAPI/WebKit2Gtk/TestPrinting fails (actually timeouts) if you pass --disable-cups to GTK+ build.

Xabier Rodríguez Calvar

Comment 11 2016-10-27 03:20:46 PDT

Created attachment 293007 [details] Patch to workaround the build

Joanmarie Diggs

Comment 12 2016-10-27 10:43:57 PDT

Comment on attachment 292102 [details] Patch This patch should once again be good.

ChangSeok Oh

Comment 13 2016-12-06 12:30:14 PST

What blocks this to land? If bumping glib and its consequence making bots red is the blocker, how about applying the change in the configure.ac to the configure directly? We don't need to bump up the glib so we don't need to worry about bots red.

Michael Catanzaro

Comment 14 2016-12-06 16:42:32 PST

Hi! (In reply to comment #13) > What blocks this to land? First patch depends on bug #163689, which looks like it would probably be pretty easy to fix (see my last comment in that bug), just nobody has tried to. Second patch uses --disable-cups, which is not OK.

ChangSeok Oh

Comment 15 2016-12-07 10:14:35 PST

Created attachment 296395 [details] Patch

Michael Catanzaro

Comment 16 2016-12-07 11:05:03 PST

Comment on attachment 296395 [details] Patch OK

ChangSeok Oh

Comment 17 2016-12-07 14:12:09 PST

Comment on attachment 296395 [details] Patch I don't know why the gtk-wk2 bot hangs on the oragne. Anyhow, this should not hurt anything.

WebKit Commit Bot

Comment 18 2016-12-07 14:37:14 PST

Comment on attachment 296395 [details] Patch Clearing flags on attachment: 296395 Committed r209482: <http://trac.webkit.org/changeset/209482>

WebKit Commit Bot

Comment 19 2016-12-07 14:37:19 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.