Bug 163590

Summary: Remove unnecessary JS_EXPORT_PRIVATEs
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, joepeck, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
saam: review+
[PATCH] For Landing none

Joseph Pecoraro
Reported 2016-10-18 01:07:25 PDT
Remove unnecessary JS_EXPORT_PRIVATEs in JavaScriptCore/debugger. These must have been pretty old they don't appear to be needed.
Attachments
[PATCH] Proposed Fix (3.42 KB, patch)
2016-10-18 01:08 PDT, Joseph Pecoraro 		saam: review+
DetailsFormatted DiffDiff
[PATCH] For Landing (3.40 KB, patch)
2016-10-18 10:47 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-10-18 01:08:07 PDT
Created attachment 291929 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2016-10-18 01:09:36 PDT
Attachment 291929 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/debugger/DebuggerScope.h:41: The parameter name "vm" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/debugger/DebuggerScope.h:41: The parameter name "scope" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 3 2016-10-18 10:47:45 PDT
Created attachment 291959 [details] [PATCH] For Landing
Joseph Pecoraro
Comment 4 2016-10-18 13:54:13 PDT
It seems some of these are necessary for WebScriptDebugger.mm. We could probably remove some of these but not all of them. Closing as WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.