| Summary: | Redirections should be upgraded if CSP policy says so | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bfulgham, buildbot, cdumez, commit-queue, dbates, japhet, mkwst, rniwa | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
youenn fablet
2016-10-17 08:10:05 PDT
Created attachment 291819 [details]
Patch
New test is passing in Firefox, but not in Chrome. Comment on attachment 291819 [details] Patch Attachment 291819 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2304869 New failing tests: http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-https-to-http-script-in-iframe.html Created attachment 291822 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 291819 [details] Patch Attachment 291819 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2305065 New failing tests: http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-https-to-http-script-in-iframe.html Created attachment 291827 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
(In reply to comment #5) > Comment on attachment 291819 [details] > Patch > > Attachment 291819 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/2305065 > > New failing tests: > http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade- > redirect-https-to-http-script-in-iframe.html This test is timing out because the new behavior upgrades the HTTPS request and we end up with a "CFNetwork SSLHandshake failed (-9847)" error. Created attachment 291944 [details]
Patch
Comment on attachment 291944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291944&action=review > Source/WebCore/loader/cache/CachedResourceLoader.cpp:503 > + if (Document* document = m_documentLoader->cachedResourceLoader().document()) I like auto* for cases like this. Created attachment 292590 [details]
Patch for landing
Thanks for the review. (In reply to comment #9) > Comment on attachment 291944 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291944&action=review > > > Source/WebCore/loader/cache/CachedResourceLoader.cpp:503 > > + if (Document* document = m_documentLoader->cachedResourceLoader().document()) > > I like auto* for cases like this. Done Comment on attachment 292590 [details] Patch for landing Clearing flags on attachment: 292590 Committed r207752: <http://trac.webkit.org/changeset/207752> All reviewed patches have been landed. Closing bug. |