Summary: | [SOUP] Downloads should always sniff contents | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bugs-noreply | ||||
Priority: | P2 | Keywords: | Gtk, Soup | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2016-10-17 03:30:06 PDT
Created attachment 291806 [details]
Patch
Comment on attachment 291806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291806&action=review > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:640 > + g_assert_cmpstr(webkit_uri_response_get_mime_type(response), ==, "application/pdf"); So what did you actually do? Does this function call fail without your change? (In reply to comment #2) > Comment on attachment 291806 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291806&action=review > > > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:640 > > + g_assert_cmpstr(webkit_uri_response_get_mime_type(response), ==, "application/pdf"); > > So what did you actually do? Does this function call fail without your > change? The assert fails, because the returned mime type is not application/pdf Committed r207405: <http://trac.webkit.org/changeset/207405> |