Summary: | [GTK] Check for deprecated API use (G_DISABLE_DEPRECATED etc.) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alp Toker <alp> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | jmalonzo | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Alp Toker
2007-12-08 05:31:57 PST
Hi! I don't see why we need another target for this. Normally, _DISABLE_DEPRECATED is part of the 'debug' profile since debug builds are usually the place for fixing this sort of things.
> These flags probably shouldn't be used in standard build profiles since they
> may cause the build to break needlessly in the long term
Just wondering what sort of build breakages are you expecting to come if we enable these flags in the 'debug' build?
(In reply to comment #1) > Hi! I don't see why we need another target for this. Normally, > _DISABLE_DEPRECATED is part of the 'debug' profile since debug builds are > usually the place for fixing this sort of things. Adding these flags only for debug builds sounds fine to me. We don't want to use them in release builds since a release build needs to be forward-compatible. Created attachment 18130 [details]
patch to define the flags mentioned during debug builds
This patch defines the flags only when doing debug builds.
cheers
Comment on attachment 18130 [details]
patch to define the flags mentioned during debug builds
r=me
There's some bad whitespace changes in WebCore.pro and you missed wrapping GST_DISABLE_DEPRECATED withCONFIG(debug) though. Will fix up before landing.
|