Bug 163526
Summary: | [GTK] Layout test media/video-controls-drop-and-restore-timeline.html is failing | ||
---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
Component: | Media | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | ahmad.saleem792, bugs-noreply, graouts, mcatanzaro |
Priority: | P2 | ||
Version: | Other | ||
Hardware: | PC | ||
OS: | Linux |
Michael Catanzaro
Layout test media/video-controls-drop-and-restore-timeline.html has been failing since it was added in r202694 "[iOS] Media controls are too cramped with small video". Updating expectations accordingly.
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-drop-and-restore-timeline-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/media/video-controls-drop-and-restore-timeline-actual.txt
@@ -4,14 +4,14 @@
EXPECTED (video.controls != 'null') OK
EVENT(canplaythrough)
EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
-EXPECTED (timelineContainer = mediaControlsElement(shadowRoot.firstChild, "-webkit-media-controls-timeline-container") != 'null') OK
+EXPECTED (timelineContainer = mediaControlsElement(shadowRoot.firstChild, "-webkit-media-controls-timeline-container") != 'null'), OBSERVED 'null' FAIL
Initital test at width = 200px
EXPECTED (video.offsetWidth == '200') OK
-EXPECTED (timelineChildrenAreDropped() == 'true') OK
-EXPECTED (timelineChildrenAreNotDisplayed() == 'true') OK
+TypeError: null is not an object (evaluating 'timelineContainer.children')
+TypeError: null is not an object (evaluating 'timelineContainer.children')
Second test at width = 500px
EXPECTED (video.offsetWidth == '500') OK
-EXPECTED (timelineChildrenAreDropped() == 'false') OK
-EXPECTED (timelineChildrenAreNotDisplayed() == 'false') OK
+TypeError: null is not an object (evaluating 'timelineContainer.children')
+TypeError: null is not an object (evaluating 'timelineContainer.children')
END OF TEST
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Following test was removed in this commit:
https://github.com/WebKit/WebKit/commit/a39bd42ad87d82a3bea0fa6eac107376a973cf7c
>> * media/video-controls-drop-and-restore-timeline.html: Removed.
Nothing to do here.