Bug 163460

Summary:

Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, buildbot, commit-queue, enrica, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

163112

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	darin: review+, buildbot: commit-queue-
Archive of layout-test-results from ews115 for mac-yosemite	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Archive of layout-test-results from ews103 for mac-yosemite	none
Fix test failures	none
Patch for landing	none

Wenson Hsieh

Reported 2016-10-14 14:39:15 PDT

Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents

Attachments
Patch (27.71 KB, patch) 2016-10-17 11:22 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (29.37 KB, patch) 2016-10-17 13:44 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (48.02 KB, patch) 2016-10-21 10:57 PDT, Wenson Hsieh	darin: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-yosemite (1.95 MB, application/zip) 2016-10-21 12:00 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.46 MB, application/zip) 2016-10-21 12:04 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews103 for mac-yosemite (898.12 KB, application/zip) 2016-10-21 12:11 PDT, Build Bot	no flags	Details
Fix test failures (51.42 KB, patch) 2016-10-21 14:57 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch for landing (51.08 KB, patch) 2016-10-21 15:34 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2016-10-14 17:01:11 PDT

<rdar://problem/28784142>

Wenson Hsieh

Comment 2 2016-10-17 11:22:05 PDT

Created attachment 291839 [details] Patch

Wenson Hsieh

Comment 3 2016-10-17 13:44:39 PDT

Created attachment 291865 [details] Patch

Wenson Hsieh

Comment 4 2016-10-17 20:04:25 PDT

Actually, we're putting this on hold for now while we clarify the following issues on the input events GitHub: https://github.com/w3c/input-events/issues/41 https://github.com/w3c/input-events/issues/42

Wenson Hsieh

Comment 5 2016-10-20 19:34:43 PDT

We have enough information for a basic implementation, but a more rigorous plan for coordinating input event dispatching with composition event dispatching is still needed.

Wenson Hsieh

Comment 6 2016-10-21 10:57:35 PDT

Created attachment 292376 [details] Patch

Build Bot

Comment 7 2016-10-21 12:00:51 PDT

Comment on attachment 292376 [details] Patch Attachment 292376 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2339417 New failing tests: editing/input/select-all-clear-input-method.html editing/mac/input/text-input-controller.html

Build Bot

Comment 8 2016-10-21 12:00:54 PDT

Created attachment 292380 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-10-21 12:04:04 PDT

Comment on attachment 292376 [details] Patch Attachment 292376 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2339441 New failing tests: editing/input/select-all-clear-input-method.html

Build Bot

Comment 10 2016-10-21 12:04:07 PDT

Created attachment 292381 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 11 2016-10-21 12:11:35 PDT

Comment on attachment 292376 [details] Patch Attachment 292376 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2339484 New failing tests: editing/input/select-all-clear-input-method.html editing/mac/input/text-input-controller.html

Build Bot

Comment 12 2016-10-21 12:11:38 PDT

Created attachment 292382 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Wenson Hsieh

Comment 13 2016-10-21 14:57:44 PDT

Created attachment 292417 [details] Fix test failures

Wenson Hsieh

Comment 14 2016-10-21 15:34:22 PDT

Created attachment 292421 [details] Patch for landing

WebKit Commit Bot

Comment 15 2016-10-21 16:08:52 PDT

Comment on attachment 292421 [details] Patch for landing Clearing flags on attachment: 292421 Committed r207698: <http://trac.webkit.org/changeset/207698>

Note You need to log in before you can comment on or make changes to this bug.