Bug 163452

Summary: 100% CPU on homedepot.com page
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: AnimationsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, dino, esprehn+autocc, kangil.han, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.homedepot.com/p/BrassCraft-Safety-PLUS-Gas-Installation-Kit-for-Dryer-and-Range-60-500-BTU-PSC1081-K5/100112627
Attachments:
Description Flags
patch simon.fraser: review+

Antti Koivisto
Reported 2016-10-14 09:59:01 PDT
The site has a keyframe animation on body. Currently this causes animation that invalidates the style of the entire document. Animations should only invalidate the element itself instead of the full subtree.
Attachments
patch (7.94 KB, patch)
2016-10-14 10:19 PDT, Antti Koivisto 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-10-14 09:59:16 PDT
<rdar://problem/28730708>
Antti Koivisto
Comment 2 2016-10-14 10:19:57 PDT
Created attachment 291644 [details] patch
Simon Fraser (smfr)
Comment 3 2016-10-14 10:23:59 PDT
Comment on attachment 291644 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=291644&action=review > Source/WebCore/ChangeLog:14 > + that causes full subtree invalidation. However animation only ever affect individual elements and > + the normal style resolution mechanism should be able to deal with things like inheritance as needed. Is this true if an animation affects a property, and the element's descendants have 'inherit' for that property?
Antti Koivisto
Comment 4 2016-10-14 10:34:47 PDT
> Is this true if an animation affects a property, and the element's > descendants have 'inherit' for that property? Yes, of course. We cache the information about use of explicit 'inherit'. Search for hasExplicitlyInheritedProperties too see the mechanism.
Simon Fraser (smfr)
Comment 5 2016-10-14 11:21:56 PDT
Comment on attachment 291644 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=291644&action=review > LayoutTests/fast/animation/animation-style-update-size.html:7 > + -webkit-animation: testframes infinite 1s; No prefix necessary. > LayoutTests/fast/animation/animation-style-update-size.html:10 > +@-webkit-keyframes testframes { No prefix necessary. > LayoutTests/fast/animation/animation-style-update-size.html:20 > +document.querySelector("body").addEventListener("animationiteration", () => { document.body
Antti Koivisto
Comment 6 2016-10-15 01:31:12 PDT
https://trac.webkit.org/changeset/207372
Note You need to log in before you can comment on or make changes to this bug.