Summary: | AX: [Mac] roleDescription for AXTextField input types | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nan Wang <n_wang> | ||||||||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, n_wang, rniwa, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Nan Wang
2016-10-13 16:50:05 PDT
Created attachment 291540 [details]
patch
Comment on attachment 291540 [details] patch Attachment 291540 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2280709 New failing tests: accessibility/roles-exposed.html Created attachment 291546 [details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 291540 [details] patch Attachment 291540 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2280738 New failing tests: accessibility/roles-exposed.html Created attachment 291548 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 291540 [details] patch Attachment 291540 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2280823 New failing tests: accessibility/roles-exposed.html Created attachment 291550 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 291556 [details]
patch
Fixed test failure.
Comment on attachment 291556 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=291556&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2520 > + Node* node = m_object->node(); Slightly better to use auto: auto* node = m_object->node(); > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2521 > + if (node && is<HTMLInputElement>(*node)) { The is<> function handles null checks if you pass it a pointer: if (is<HTMLInputElement>(node)) { > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2522 > + HTMLInputElement& input = downcast<HTMLInputElement>(*node); Best style is to not repeat the type: auto& input = downcast<HTMLInputElement>(*node); > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2531 > + const AtomicString& type = m_object->getAttribute(typeAttr); Should write: auto& type = input.attributeWithoutSynchronization(typeAttr); Instead of going back to the accessibility object, now that we know this is an input element. Committed r207401: <http://trac.webkit.org/changeset/207401> committed with changes |