Summary: | [GTK] WebKitWebPage URI not updated after URI is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | 146306, 163436 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Michael Catanzaro
2016-10-13 08:57:44 PDT
Created attachment 291603 [details]
Patch
(In reply to comment #0) > InjectedBundlePageResourceLoadClient::willSendRequestForFrame() allows > clients to modify the ResourceRequest passed to it. We rely on this in the > GTK+ API in order to allow a web extension to modify URLs before they are > loaded. F F? What were you thinking, myself? Comment on attachment 291603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291603&action=review > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:408 > + void loadURI(const char* uri) Eventually we should start using override in our unit test classes. Committed r207389: <http://trac.webkit.org/changeset/207389> |