Bug 163364

Summary: Expose SPI to disable synchronously blocking on painting after parenting a WKWebView
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, barraclough, bdakin, commit-queue, mitz, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Description Tim Horton 2016-10-12 15:18:18 PDT 
Expose SPI to disable synchronously blocking on painting after parenting a WKWebView
Comment 1 Tim Horton 2016-10-12 15:18:59 PDT 
Created attachment 291406 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-12 15:21:38 PDT 
Attachment 291406 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2016-10-12 17:04:21 PDT 
Comment on attachment 291406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291406&action=review

r=me

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:661
> +- (BOOL)_shouldSynchronizeInitialPaintAfterMovingToWindow

The AppKit API name for the moment of "moving to window" is "viewDidMoveToWindow".

Maybe we should call this _shouldSynchronizeFirstPaintAfterViewDidMoveToWindow.
Comment 4 Tim Horton 2016-10-12 17:35:30 PDT 
Comment on attachment 291406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291406&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:661
>> +- (BOOL)_shouldSynchronizeInitialPaintAfterMovingToWindow
> 
> The AppKit API name for the moment of "moving to window" is "viewDidMoveToWindow".
> 
> Maybe we should call this _shouldSynchronizeFirstPaintAfterViewDidMoveToWindow.

smfr suggests _waitForPaintAfterViewDidMoveToWindow
Comment 5 Tim Horton 2016-10-13 10:51:45 PDT 
https://trac.webkit.org/changeset/207292
Comment 6 Tim Horton 2016-10-13 12:01:58 PDT 
Reopening to attach new patch.
Comment 7 Tim Horton 2016-10-13 12:02:00 PDT 
Created attachment 291503 [details]
Patch
Comment 8 WebKit Commit Bot 2016-10-13 12:03:17 PDT 
Attachment 291503 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Tim Horton 2016-10-13 12:05:16 PDT 
Renamed in https://trac.webkit.org/changeset/207298