Bug 163364

Summary: Expose SPI to disable synchronously blocking on painting after parenting a WKWebView
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, barraclough, bdakin, commit-queue, mitz, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Tim Horton
Reported 2016-10-12 15:18:18 PDT
Expose SPI to disable synchronously blocking on painting after parenting a WKWebView
Attachments
Patch (9.31 KB, patch)
2016-10-12 15:18 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (10.28 KB, patch)
2016-10-13 12:02 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-10-12 15:18:59 PDT
Created attachment 291406 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-12 15:21:38 PDT
Attachment 291406 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:0: Use #pragma once header guard. [build/header_guard] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2016-10-12 17:04:21 PDT
Comment on attachment 291406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291406&action=review r=me > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:661 > +- (BOOL)_shouldSynchronizeInitialPaintAfterMovingToWindow The AppKit API name for the moment of "moving to window" is "viewDidMoveToWindow". Maybe we should call this _shouldSynchronizeFirstPaintAfterViewDidMoveToWindow.
Tim Horton
Comment 4 2016-10-12 17:35:30 PDT
Comment on attachment 291406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291406&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:661 >> +- (BOOL)_shouldSynchronizeInitialPaintAfterMovingToWindow > > The AppKit API name for the moment of "moving to window" is "viewDidMoveToWindow". > > Maybe we should call this _shouldSynchronizeFirstPaintAfterViewDidMoveToWindow. smfr suggests _waitForPaintAfterViewDidMoveToWindow
Tim Horton
Comment 5 2016-10-13 10:51:45 PDT
https://trac.webkit.org/changeset/207292
Tim Horton
Comment 6 2016-10-13 12:01:58 PDT
Reopening to attach new patch.
Tim Horton
Comment 7 2016-10-13 12:02:00 PDT
Created attachment 291503 [details] Patch
WebKit Commit Bot
Comment 8 2016-10-13 12:03:17 PDT
Attachment 291503 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:0: Use #pragma once header guard. [build/header_guard] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 9 2016-10-13 12:05:16 PDT
Renamed in https://trac.webkit.org/changeset/207298
Note You need to log in before you can comment on or make changes to this bug.