Bug 163363 – Add API to restrict WebKit processes to background priority

• Component: WebKit2
• Status: RESOLVED FIXED

[Gavin Barraclough]

This may be useful to some clients.

[Gavin Barraclough]

Created attachment 291641 [details]
Fix

[WebKit Commit Bot]

Attachment 291641 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 291641 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=291641&action=review

> Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h:112
> +    bool alwaysRunsAtBackgroundPriority() const { return m_alwaysRunsAtBackgroundPriority; }
> +    void setAlwaysRunsAtBackgroundPriority(bool alwaysRunsAtBackgroundPriority) { m_alwaysRunsAtBackgroundPriority = alwaysRunsAtBackgroundPriority; }

I believe the copy function needs to copy this member variable.

[Gavin Barraclough]

Committed revision 207346.

[Simon Fraser (smfr)]

Comment on attachment 291641 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=291641&action=review

> Source/WebKit2/UIProcess/WebProcessPool.h:369
> +    bool alwaysRunsAtBackgroundPriority() { return m_alwaysRunsAtBackgroundPriority; }

This should be const.

> Source/WebKit2/UIProcess/WebProcessProxy.h:211
> +    bool alwaysRunsAtBackgroundPriority() override;

Can this be const?