Summary: | REGRESSION (r207179): ASSERTION FAILED: node.cell != previousCell | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 149432 | ||||||
Attachments: |
|
Description
Ryan Haddad
2016-10-12 09:53:36 PDT
Started with https://trac.webkit.org/changeset/207179 Seen with these tests on all mac debug builds: inspector/console/heapSnapshot.html inspector/timeline/setInstruments-programmatic-capture.html https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r207192%20(299)/results.html I have a fix! Created attachment 291371 [details]
the patch
Comment on attachment 291371 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=291371&action=review r=me > Source/JavaScriptCore/heap/HeapSnapshot.cpp:126 > ASSERT(node.cell != previousCell); Should this be a RELEASE_ASSERT? Comment on attachment 291371 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=291371&action=review >> Source/JavaScriptCore/heap/HeapSnapshot.cpp:126 >> ASSERT(node.cell != previousCell); > > Should this be a RELEASE_ASSERT? It could be. But we're in a #ifndef NDEBUG block, so it wouldn't do any good. Patch was landed in r207230: <https://trac.webkit.org/changeset/207230>. |