Bug 163334

Summary: Remove JITWriteBarrier.h
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch mark.lam: review+

Description Filip Pizlo 2016-10-12 09:07:06 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-10-12 09:13:19 PDT 
Created attachment 291359 [details]
the patch
Comment 2 WebKit Commit Bot 2016-10-12 09:15:44 PDT 
Attachment 291359 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-10-12 09:19:56 PDT 
Created attachment 291361 [details]
the patch
Comment 4 WebKit Commit Bot 2016-10-12 09:21:14 PDT 
Attachment 291361 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Mark Lam 2016-10-12 09:38:56 PDT 
Comment on attachment 291361 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291361&action=review

r=me with fixes.

> Source/JavaScriptCore/ChangeLog:14
> +        one by overwhelming majority, so we should finally remove JITWriteBarrier.

typo: /one/won/.

> Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:34
>  #include "Opcode.h"
> +#include "MacroAssembler.h"

Please fix ordering: M before O.
Comment 6 Filip Pizlo 2016-10-12 09:39:54 PDT 
(In reply to comment #5)
> Comment on attachment 291361 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291361&action=review
> 
> r=me with fixes.
> 
> > Source/JavaScriptCore/ChangeLog:14
> > +        one by overwhelming majority, so we should finally remove JITWriteBarrier.
> 
> typo: /one/won/.

Oops.

> 
> > Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:34
> >  #include "Opcode.h"
> > +#include "MacroAssembler.h"
> 
> Please fix ordering: M before O.

Ooops.
Comment 7 Filip Pizlo 2016-10-12 09:59:32 PDT 
Landed in https://trac.webkit.org/changeset/207222