Bug 163334

Summary: Remove JITWriteBarrier.h
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch mark.lam: review+

Filip Pizlo
Reported 2016-10-12 09:07:06 PDT
Patch forthcoming.
Attachments
the patch (14.20 KB, patch)
2016-10-12 09:13 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (15.02 KB, patch)
2016-10-12 09:19 PDT, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-10-12 09:13:19 PDT
Created attachment 291359 [details] the patch
WebKit Commit Bot
Comment 2 2016-10-12 09:15:44 PDT
Attachment 291359 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2016-10-12 09:19:56 PDT
Created attachment 291361 [details] the patch
WebKit Commit Bot
Comment 4 2016-10-12 09:21:14 PDT
Attachment 291361 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 5 2016-10-12 09:38:56 PDT
Comment on attachment 291361 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=291361&action=review r=me with fixes. > Source/JavaScriptCore/ChangeLog:14 > + one by overwhelming majority, so we should finally remove JITWriteBarrier. typo: /one/won/. > Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:34 > #include "Opcode.h" > +#include "MacroAssembler.h" Please fix ordering: M before O.
Filip Pizlo
Comment 6 2016-10-12 09:39:54 PDT
(In reply to comment #5) > Comment on attachment 291361 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291361&action=review > > r=me with fixes. > > > Source/JavaScriptCore/ChangeLog:14 > > + one by overwhelming majority, so we should finally remove JITWriteBarrier. > > typo: /one/won/. Oops. > > > Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:34 > > #include "Opcode.h" > > +#include "MacroAssembler.h" > > Please fix ordering: M before O. Ooops.
Filip Pizlo
Comment 7 2016-10-12 09:59:32 PDT
Landed in https://trac.webkit.org/changeset/207222
Note You need to log in before you can comment on or make changes to this bug.