Bug 163318

Summary:

Add an option to validate-committer-lists to retire inactive committers and reviewers

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

cdumez, commit-queue, dbates, glenn, joepeck, mitz, ossy, rniwa, sam, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=115387
https://bugs.webkit.org/show_bug.cgi?id=153591

Attachments:

Description	Flags
Patch	none
Patch	dbates: review+

Simon Fraser (smfr)

Reported 2016-10-11 22:15:36 PDT

Add an option to validate-committer-lists to retire inactive committers and reviewers

Attachments
Patch (14.21 KB, patch) 2016-10-11 22:23 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (20.89 KB, patch) 2016-10-13 22:11 PDT, Simon Fraser (smfr)	dbates: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2016-10-11 22:23:04 PDT

Created attachment 291332 [details] Patch

Simon Fraser (smfr)

Comment 2 2016-10-11 22:23:56 PDT

Running --retire makes the following changes: 45$ $ ./Tools/Scripts/validate-committer-lists -r Finding inactive reviewers and committers (this may take a while)... Making the following reviewers inactive: Retiring reviewer: Tim Omernick Retiring reviewer: Laszlo Gombos Retiring reviewer: Holger Freyther Retiring reviewer: Jochen Eisinger Retiring reviewer: Chang Shu Retiring reviewer: Alice Liu Inactive reviewer committed, considered active: Jon Honeycutt Retiring reviewer: Ojan Vafai Retiring reviewer: Stephen Chenney Retiring reviewer: Cameron Zwarich Retiring reviewer: Kenneth Rohde Christiansen Retiring reviewer: Steve Block Retiring reviewer: Chris Rogers Retiring reviewer: Dirk Pranke Retiring reviewer: Pratik Solanki Retiring reviewer: Pavel Feldman Retiring reviewer: John Sullivan Retiring reviewer: Xan Lopez Retiring reviewer: Darin Fisher Retiring reviewer: Philip Rogers Retiring reviewer: Vicki Murley Retiring reviewer: Ken Kocienda Retiring reviewer: Dumitru Daniliuc Retiring reviewer: Maciej Stachowiak Retiring reviewer: Jian Li Retiring reviewer: Mihai Parparita Retiring reviewer: Nate Chapin Retiring reviewer: Alexander Pavlov Retiring reviewer: Noam Rosenthal Retiring reviewer: Kenneth Russell Retiring reviewer: Kevin Ollivier Retiring reviewer: Mihnea Ovidenie Retiring reviewer: George Staikos Retiring reviewer: Chris Blumenberg Retiring reviewer: Yury Semikhatsky Retiring reviewer: Alexandru Chiculita Retiring reviewer: Rob Buis Retiring reviewer: Justin Garcia Retiring reviewer: Allan Sandfeld Jensen Retiring reviewer: Adrienne Walker Retiring reviewer: Emil A Eklund Retiring reviewer: Tor Arne Vestbø Retiring reviewer: Kent Tamura Retiring reviewer: Mark Rowe Retiring reviewer: David Harrison Retiring reviewer: Stephen White Retiring reviewer: Kevin McCullough Retiring reviewer: Jan Alonzo Inactive reviewer committed, considered active: Sukolsak Sakshuwong Retiring reviewer: Vsevolod Vlasov Retiring reviewer: Caio Marcelo de Oliveira Filho Retiring reviewer: James Robinson Retiring reviewer: Yuta Kitamura Retiring reviewer: Tony Gentilcore Retiring reviewer: Chris Marrin Retiring reviewer: Jocelyn Turcotte Retiring reviewer: Kevin Decker Retiring reviewer: Yong Li Retiring reviewer: Andrei Bucur Retiring reviewer: Adam Barth Retiring reviewer: Richard Williamson Retiring reviewer: Hajime Morrita Retiring reviewer: Dirk Schulze Retiring reviewer: Adele Peterson Retiring reviewer: Adam Treat Retiring reviewer: David Levin Retiring reviewer: Elliott Sprehn Retiring reviewer: Julien Chaffraix Retiring reviewer: Shinichiro Hamaji Retiring reviewer: Luiz Agostini Retiring reviewer: Tony Chang Retiring reviewer: Lars Knoll Retiring reviewer: Nico Weber Inactive reviewer committed, considered active: Nan Wang Retiring reviewer: Kentaro Hara Retiring reviewer: Alexis Menard Retiring reviewer: Jeremy Orlow Retiring reviewer: Alp Toker Retiring reviewer: Simon Hausmann Retiring reviewer: Mark Hahnenberg Retiring reviewer: Eric Seidel Retiring reviewer: Zack Rusin Retiring reviewer: Chris Jerdonek Retiring reviewer: Abhishek Arya Retiring reviewer: Don Melton Retiring reviewer: Ariya Hidayat Retiring reviewer: Zoltan Horvath Retiring reviewer: Bem Jones-Bey Retiring reviewer: Steve Falkenburg Retiring reviewer: Levi Weintraub Retiring reviewer: Dimitri Glazkov Retiring reviewer: Adam Roben Retiring reviewer: Dmitry Titov Retiring reviewer: Nikolas Zimmermann Making the following committers inactive: Retiring committer: Jae Hyun Park Retiring committer: Simon Pena Retiring committer: Anthony Ricaud Retiring committer: Dana Jansens Retiring committer: Pierre d'Herbemont Retiring committer: Andre Boule Retiring committer: Zeno Albisser Retiring committer: Satish Sampath Retiring committer: Alexandre Elias Retiring committer: Xianzhu Wang Retiring committer: Dominic Mazzoni Retiring committer: Dongwoo Joshua Im Retiring committer: Ruth Fong Retiring committer: Xiaomei Ji Retiring committer: Michael Brüning Retiring committer: Nima Ghanavatian Retiring committer: Kiran Muppala Retiring committer: Ion Rosca Retiring committer: Mikhail Pozdnyakov Retiring committer: Michael Nordman Retiring committer: Collin Jackson Retiring committer: Ben Wells Retiring committer: Dominik Röttsches Retiring committer: Pierre Rossi Retiring committer: Igor Trindade Oliveira Retiring committer: Mads Ager Retiring committer: Anna Cavender Retiring committer: Dongseong Hwang Retiring committer: Kenji Imasaki Retiring committer: Mary Wu Retiring committer: Cary Clark Retiring committer: Andrew Wellington Retiring committer: Ademar de Souza Reis Jr Retiring committer: Arko Saha Retiring committer: Tibor Meszaros Retiring committer: Devin Rousso Retiring committer: Marcelo Lira Retiring committer: Byungseon Shin Retiring committer: Matt Rajca Retiring committer: Leandro Gracia Gil Retiring committer: Kaustubh Atrawalkar Retiring committer: Jia Pu Retiring committer: Ami Fischman Retiring committer: Bear Travis Retiring committer: Taiju Tsuiki Retiring committer: Mikhail Naganov Retiring committer: Charles Reis Retiring committer: Joone Hur Retiring committer: Shinya Kawanaka Retiring committer: Kwang Yul Seo Retiring committer: Dániel Bátyai Retiring committer: Mihai Tica Retiring committer: Brendan Long Retiring committer: Victor Jaquez Retiring committer: Helder Correia Retiring committer: Michelangelo De Simone Retiring committer: Tobias Reiss Retiring committer: Jinwoo Song Retiring committer: Denis Nomiyama Retiring committer: Thomas Sepez Retiring committer: Eric Roman Retiring committer: Aaron Boodman Retiring committer: Karen Grunberg Retiring committer: Andrey Kosyakov Retiring committer: Pierre-Olivier Latour Retiring committer: Kim Grönholm Retiring committer: Victor Wang Retiring committer: Lauro Neto Retiring committer: Alice Boxhall Retiring committer: Tom Hudson Retiring committer: Anton Muhin Retiring committer: Drew Wilson Retiring committer: Christian Dywan Retiring committer: Kelly Norton Retiring committer: Glenn Adams Retiring committer: Benjamin Kalman Retiring committer: Peter Varga Retiring committer: Nat Duca Retiring committer: Hugo Parente Lima Retiring committer: Santosh Mahto Retiring committer: David Grogan Retiring committer: Gabor Loki Retiring committer: Eugene Klyuchnikov Retiring committer: Adam Langley Retiring committer: Jesus Sanchez-Palencia Retiring committer: Eli Fidler Retiring committer: Chris Petersen Retiring committer: Robert Hogan Retiring committer: Kent Hansen Retiring committer: Hin-Chung Lam Retiring committer: Thiago de Barros Lacerda Retiring committer: Adam Kallai Retiring committer: Peter Molnar Retiring committer: Krzysztof Kowalczyk Retiring committer: Kimmo Kinnunen Retiring committer: Mahesh Kulkarni Retiring committer: Daniel Cheng Retiring committer: Kihong Kwon Retiring committer: Thiago Marcos P. Santos Retiring committer: Shawn Singh Retiring committer: Aaron Colwell Retiring committer: Sadrul Habib Chowdhury Retiring committer: Naoki Takano Retiring committer: Cosmin Truta Retiring committer: Alexander Færøy Retiring committer: Chris Guillory Retiring committer: Matt Lilek Retiring committer: Andres Gomez Retiring committer: Ian Vollick Retiring committer: Janos Badics Retiring committer: Justin Novosad Inactive committer reviewed, considered active: Zoltan Herczeg Retiring committer: Erik Arvidsson Retiring committer: Luciano Wolf Retiring committer: John Abd-El-Malek Retiring committer: Pam Greene Retiring committer: David Smith Retiring committer: Ilya Sherman Retiring committer: Maxime Britto Retiring committer: Amruth Raj Retiring committer: Dan Winship Retiring committer: Mark Pilgrim Retiring committer: Joshua Bell Retiring committer: Marcus Voltis Bulach Retiring committer: Samuel White Retiring committer: John Knottenbelt Retiring committer: Dmitry Gorbik Retiring committer: Julie Parent Retiring committer: Roland Steiner Retiring committer: Jay Civelli Retiring committer: Mike Lawther Retiring committer: Evan Stade Retiring committer: Zsolt Borbely Retiring committer: Terry Anderson Retiring committer: Cris Neckar Retiring committer: Roland Takacs Retiring committer: Diego Pino Garcia Retiring committer: Evan Martin Retiring committer: Jens Alfke Retiring committer: Seokju Kwon Retiring committer: Carol Szabo Retiring committer: Dinu Jacob Retiring committer: Nick Diego Yamane Retiring committer: Gabor Rapcsanyi Retiring committer: Vineet Chaudhary Retiring committer: Kangil Han Retiring committer: Trey Matteson Retiring committer: Graham Dennis Retiring committer: Jason Liu Retiring committer: Elliot Poger Retiring committer: Hans Wennborg Retiring committer: Rafael Brandao Retiring committer: Pravin D Retiring committer: Noel Gordon Retiring committer: Dave Barton Retiring committer: Viatcheslav Ostapenko Retiring committer: Bruno de Oliveira Abinader Retiring committer: Szilard Ledan-Muntean Retiring committer: Dominic Cooney Retiring committer: Girish Ramakrishnan Retiring committer: Rik Cabanier Retiring committer: Jacky Jiang Retiring committer: Vivek Galatage Retiring committer: Ilya Tikhonovsky Retiring committer: Jenn Braithwaite Retiring committer: Shivakumar J M Retiring committer: Kristof Kosztyo Retiring committer: Kinuko Yasuda Retiring committer: Antoine Labour Retiring committer: Raymond Toy Retiring committer: Vitaly Repeshko Retiring committer: Fady Samuel Retiring committer: Takashi Toyoshima Retiring committer: Tom Zakrajsek Retiring committer: Alec Flett Retiring committer: Roger Fong Retiring committer: Jarred Nicholls Retiring committer: Balazs Kelemen Retiring committer: William Siegrist Retiring committer: Mike Thole Retiring committer: Takashi Sakamoto Retiring committer: Li Yin Retiring committer: Diego Gonzalez Retiring committer: Gurpreet Kaur Retiring committer: Feng Qian Retiring committer: László Langó Retiring committer: Bill Budge Retiring committer: Martin Hock Retiring committer: Ivan Ivan Krstić Inactive committer reviewed, considered active: Stephanie Lewis Retiring committer: Tamas Gergely Retiring committer: Anton D'Auria Retiring committer: Jeffrey Pfau Retiring committer: Yuzo Fujishima Retiring committer: Matt Perry Retiring committer: Yuqiang Xian Retiring committer: Sergio Correia Retiring committer: Jeremy Moskovich Retiring committer: Jake Nielsen Retiring committer: Radu Stavila Retiring committer: Gregg Tavares Retiring committer: Dmitry Lomov Retiring committer: Kenichi Ishibashi Retiring committer: Zoltan Arvai Retiring committer: Nayan Kumar K Retiring committer: Tommy Widenflycht Retiring committer: Lucas De Marchi Retiring committer: Albert J. Wong Retiring committer: Victor Carbune Retiring committer: Ben Murdoch Retiring committer: Charles Wei Retiring committer: Dave Tharp Retiring committer: Jakub Wieczorek Retiring committer: Nadav Rotem Retiring committer: Alexander Kellett Retiring committer: Matthew Mirman Retiring committer: Kalyan Kondapally Retiring committer: Pablo Flouret Retiring committer: Mike Reed Retiring committer: Patrick Gansterer Retiring committer: Jakob Petsovits Retiring committer: Tristan O'Tierney Retiring committer: Matt Falkenhagen Retiring committer: Yaar Schnitman Retiring committer: Andy Wingo Retiring committer: Andrew Scherkus Retiring committer: Sudarsana Nagineni Retiring committer: Steve Lacey Retiring committer: Alok Priyadarshi Retiring committer: Mike Fenton Retiring committer: Michał Pakuła vel Rutka Retiring committer: Andras Becsi Retiring committer: Justin Schuh Retiring committer: Chris Evans Retiring committer: Eva Balazsfalvi Retiring committer: Matt Delaney Retiring committer: Cameron McCormack Retiring committer: Rafael Weinstein Retiring committer: Andrey Adaykin Retiring committer: Hironori Bono Retiring committer: Vangelis Kokkevis Retiring committer: Yi Shen Retiring committer: Andrzej Badowski Retiring committer: John Gregg Retiring committer: Hans Muller Retiring committer: Greg Bolsinga Retiring committer: Basile Clement Retiring committer: Anton Obzhirov Retiring committer: Keishi Hattori Retiring committer: Arvid Nilsson Retiring committer: Joe Thomas Retiring committer: Brian Holt Retiring committer: Robert Kroeger Retiring committer: Xingnan Wang Retiring committer: Peter Gal Retiring committer: Xiaohai Wei Retiring committer: Joost de Valk Retiring committer: Andrew Lo Retiring committer: Peter Beverloo Retiring committer: Siddharth Mathur Retiring committer: Konrad Piascik Retiring committer: Jono Wells Retiring committer: Raphael Kubo da Costa Retiring committer: James Kozianski Retiring committer: Ravi Kasibhatla Retiring committer: Laszlo Vidacs Retiring committer: Jungshik Shin Retiring committer: Hyowon Kim Retiring committer: Benjamin Otte Retiring committer: Andrei Popescu Retiring committer: Dhi Aurrahman Retiring committer: Sami Kyöstilä Retiring committer: Ken Buchanan Retiring committer: Silvia Pfeiffer Retiring committer: Luke Macpherson Retiring committer: Arpita Bahuguna Retiring committer: James Hawkins Retiring committer: Leo Yang Retiring committer: Pavel Podivilov Retiring committer: James Simonsen Retiring committer: Mihai Maerean Retiring committer: Arno Renevier Retiring committer: Florin Malita Retiring committer: Qi Zhang Retiring committer: Jonathan Dong Retiring committer: Yael Aharon Retiring committer: Eric Uhrhane Retiring committer: Fumitoshi Ukai Retiring committer: Mike West Retiring committer: Brett Wilson Retiring committer: Peter Kasting Retiring committer: Yoshifumi Inoue Retiring committer: Michael Pruett Retiring committer: Zhenyao Mo Retiring committer: Vincent Scheib Retiring committer: Victoria Kirst Retiring committer: Renata Hodovan Retiring committer: Max Vujovic Retiring committer: David Farler Retiring committer: W. James MacLean Retiring committer: Leandro Pereira Retiring committer: Hayato Ito Retiring committer: Matt Daiter Retiring committer: Gavin Peters Retiring committer: Benjamin C Meyer Retiring committer: Byungwoo Lee Retiring committer: Johnny Ding Retiring committer: Adam Klein Retiring committer: David Michael Barr

Simon Fraser (smfr)

Comment 3 2016-10-11 22:25:19 PDT

I decided to mark committers as inactive so they don't show up on https://webkit.org/team/ We still have some inactive Contributors (neither committers nor reviewers) who are still on that page. Maybe we need to look for the last bugzilla activity?

Joseph Pecoraro

Comment 4 2016-10-12 00:35:46 PDT

> Making the following committers inactive: > ... > Retiring committer: Devin Rousso This does not make sense. Devin has commits as recently as this week (10/6/2016). <https://trac.webkit.org/search?q=devin+rousso>

Csaba Osztrogonác

Comment 5 2016-10-12 05:19:17 PDT

(In reply to comment #4) > > Making the following committers inactive: > > ... > > Retiring committer: Devin Rousso > > This does not make sense. Devin has commits as recently as this week > (10/6/2016). > <https://trac.webkit.org/search?q=devin+rousso> It seems the patches landed via commit queue aren't counted by this script. Devin's last manually commited change was more than a year: https://trac.webkit.org/changeset/188733

Chris Dumez

Comment 6 2016-10-12 07:42:07 PDT

(In reply to comment #5) > (In reply to comment #4) > > > Making the following committers inactive: > > > ... > > > Retiring committer: Devin Rousso > > > > This does not make sense. Devin has commits as recently as this week > > (10/6/2016). > > <https://trac.webkit.org/search?q=devin+rousso> > > It seems the patches landed via commit queue aren't counted by this > script. Devin's last manually commited change was more than a year: > https://trac.webkit.org/changeset/188733 We encourage people to use the commit queue. Isn't it a problem if the script does not account for patches committed via CQ?

Simon Fraser (smfr)

Comment 7 2016-10-12 08:38:37 PDT

The script uses the git <author> of a commit, which CQ correctly sets to the patch author in most cases, but in some cases commit-queue shows up as patch author: commit cd903fc8f8f6742ed3d45e6e34d72f8767a38aca Author: commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Thu Oct 6 23:11:01 2016 +0000 Maybe this is when the author doesn't have commit privs yet? I can try to fix the script to deal with that case by grepping for "Patch by".

Simon Fraser (smfr)

Comment 8 2016-10-12 08:46:19 PDT

Actually it looks like commit-queue@webkit.org is both <author> and <committer> in git, since svn isn't able to distinguish both (unless we do something like https://github.com/Bioconductor/BiocGithubHelp/wiki/Preserve-git-committer-in-dcommit). This is unfortunate.

Csaba Osztrogonác

Comment 9 2016-10-12 08:54:25 PDT

Author is commit-queue@webkit.org only if the original author's e-mail address doesn't have valid commit rights for the SVN server. If you have commit rigths, an SVN post commit hook fixes the author field. But it can't do it if the committer use different mail address in the changelog.

Csaba Osztrogonác

Comment 10 2016-10-12 09:21:18 PDT

suggestnominations.py already has a logic to parse "Patch by" line first and then the author field. We could reuse that code.

Simon Fraser (smfr)

Comment 11 2016-10-12 09:26:58 PDT

Thanks, I'll take a look.

Simon Fraser (smfr)

Comment 12 2016-10-13 22:11:38 PDT

Created attachment 291566 [details] Patch

Simon Fraser (smfr)

Comment 13 2016-10-13 22:12:21 PDT

Output from this patch (which fixes the commit-queue issue): Making the following reviewers inactive: Retiring reviewer: Tim Omernick Retiring reviewer: Laszlo Gombos Retiring reviewer: Holger Freyther Retiring reviewer: Jochen Eisinger Retiring reviewer: Chang Shu Retiring reviewer: Alice Liu Inactive reviewer committed, considered active: Jon Honeycutt Retiring reviewer: Ojan Vafai Retiring reviewer: Stephen Chenney Retiring reviewer: Cameron Zwarich Retiring reviewer: Kenneth Rohde Christiansen Retiring reviewer: Steve Block Retiring reviewer: Chris Rogers Retiring reviewer: Dirk Pranke Retiring reviewer: Pratik Solanki Retiring reviewer: Pavel Feldman Retiring reviewer: John Sullivan Inactive reviewer committed, considered active: Xan Lopez Retiring reviewer: Darin Fisher Inactive reviewer committed, considered active: Philip Rogers Retiring reviewer: Vicki Murley Retiring reviewer: Ken Kocienda Retiring reviewer: Dumitru Daniliuc Retiring reviewer: Maciej Stachowiak Retiring reviewer: Jian Li Retiring reviewer: Mihai Parparita Retiring reviewer: Nate Chapin Retiring reviewer: Alexander Pavlov Retiring reviewer: Noam Rosenthal Retiring reviewer: Kenneth Russell Retiring reviewer: Kevin Ollivier Retiring reviewer: Mihnea Ovidenie Retiring reviewer: George Staikos Retiring reviewer: Chris Blumenberg Retiring reviewer: Yury Semikhatsky Retiring reviewer: Alexandru Chiculita Retiring reviewer: Rob Buis Retiring reviewer: Justin Garcia Retiring reviewer: Allan Sandfeld Jensen Retiring reviewer: Adrienne Walker Retiring reviewer: Emil A Eklund Retiring reviewer: Tor Arne Vestbø Retiring reviewer: Kent Tamura Retiring reviewer: Mark Rowe Retiring reviewer: David Harrison Retiring reviewer: Stephen White Retiring reviewer: Kevin McCullough Retiring reviewer: Jan Alonzo Inactive reviewer committed, considered active: Sukolsak Sakshuwong Retiring reviewer: Vsevolod Vlasov Retiring reviewer: Caio Marcelo de Oliveira Filho Retiring reviewer: James Robinson Retiring reviewer: Yuta Kitamura Retiring reviewer: Tony Gentilcore Retiring reviewer: Chris Marrin Retiring reviewer: Jocelyn Turcotte Retiring reviewer: Kevin Decker Retiring reviewer: Yong Li Retiring reviewer: Andrei Bucur Retiring reviewer: Adam Barth Retiring reviewer: Richard Williamson Retiring reviewer: Hajime Morrita Retiring reviewer: Dirk Schulze Retiring reviewer: Adele Peterson Retiring reviewer: Adam Treat Retiring reviewer: David Levin Retiring reviewer: Elliott Sprehn Retiring reviewer: Julien Chaffraix Retiring reviewer: Shinichiro Hamaji Retiring reviewer: Luiz Agostini Retiring reviewer: Tony Chang Retiring reviewer: Lars Knoll Retiring reviewer: Nico Weber Inactive reviewer committed, considered active: Nan Wang Retiring reviewer: Kentaro Hara Retiring reviewer: Alexis Menard Retiring reviewer: Jeremy Orlow Retiring reviewer: Alp Toker Retiring reviewer: Simon Hausmann Retiring reviewer: Mark Hahnenberg Retiring reviewer: Eric Seidel Retiring reviewer: Zack Rusin Retiring reviewer: Chris Jerdonek Retiring reviewer: Abhishek Arya Retiring reviewer: Don Melton Retiring reviewer: Ariya Hidayat Retiring reviewer: Zoltan Horvath Retiring reviewer: Bem Jones-Bey Retiring reviewer: Steve Falkenburg Retiring reviewer: Levi Weintraub Retiring reviewer: Dimitri Glazkov Retiring reviewer: Adam Roben Retiring reviewer: Dmitry Titov Retiring reviewer: Nikolas Zimmermann Making the following committers inactive: Retiring committer: Viatcheslav Ostapenko Retiring committer: Jae Hyun Park Retiring committer: Simon Pena Retiring committer: Anthony Ricaud Retiring committer: Dana Jansens Retiring committer: Pierre d'Herbemont Retiring committer: Andre Boule Retiring committer: Zeno Albisser Retiring committer: Satish Sampath Retiring committer: Alexandre Elias Retiring committer: Xianzhu Wang Retiring committer: Dominic Mazzoni Retiring committer: Dongwoo Joshua Im Retiring committer: Tristan O'Tierney Retiring committer: Ruth Fong Retiring committer: Xiaomei Ji Retiring committer: Michael Brüning Retiring committer: Kiran Muppala Retiring committer: Ion Rosca Retiring committer: Mikhail Pozdnyakov Retiring committer: Girish Ramakrishnan Retiring committer: Collin Jackson Retiring committer: Ben Wells Retiring committer: Dominik Röttsches Retiring committer: Pierre Rossi Retiring committer: Nick Diego Yamane Retiring committer: Igor Trindade Oliveira Retiring committer: Mads Ager Retiring committer: Dongseong Hwang Retiring committer: Kenji Imasaki Retiring committer: Mary Wu Retiring committer: Cary Clark Retiring committer: Andrew Wellington Retiring committer: Jia Pu Retiring committer: Ademar de Souza Reis Jr Retiring committer: Arko Saha Retiring committer: Tibor Meszaros Retiring committer: Marcelo Lira Retiring committer: Byungseon Shin Retiring committer: Matt Rajca Retiring committer: Leandro Gracia Gil Retiring committer: Kaustubh Atrawalkar Retiring committer: Ami Fischman Retiring committer: Bear Travis Retiring committer: Taiju Tsuiki Retiring committer: Mikhail Naganov Retiring committer: Charles Reis Retiring committer: Joone Hur Retiring committer: Shinya Kawanaka Retiring committer: Kwang Yul Seo Retiring committer: Dániel Bátyai Retiring committer: Mihai Tica Retiring committer: Brendan Long Retiring committer: Victor Jaquez Retiring committer: Helder Correia Retiring committer: Michelangelo De Simone Retiring committer: Tobias Reiss Retiring committer: Andrew Scherkus Retiring committer: Denis Nomiyama Retiring committer: Vitaly Repeshko Retiring committer: Eric Roman Retiring committer: Aaron Boodman Retiring committer: Karen Grunberg Retiring committer: Andrey Kosyakov Retiring committer: Pierre-Olivier Latour Retiring committer: Kim Grönholm Retiring committer: Victor Wang Retiring committer: Rafael Antognolli Retiring committer: Lauro Neto Retiring committer: Alice Boxhall Retiring committer: Tom Hudson Retiring committer: Tamas Gergely Retiring committer: Anton Muhin Retiring committer: Drew Wilson Retiring committer: Maxime Simon Retiring committer: Thomas Sepez Retiring committer: Christian Dywan Retiring committer: Kelly Norton Retiring committer: Glenn Adams Retiring committer: Benjamin Kalman Retiring committer: Peter Varga Retiring committer: Nat Duca Retiring committer: Hugo Parente Lima Retiring committer: Santosh Mahto Retiring committer: Maxime Britto Retiring committer: Gabor Loki Retiring committer: Eugene Klyuchnikov Retiring committer: Tom Zakrajsek Retiring committer: Adam Langley Retiring committer: Jesus Sanchez-Palencia Retiring committer: Eli Fidler Retiring committer: Chris Petersen Retiring committer: Kent Hansen Retiring committer: Hin-Chung Lam Retiring committer: Ken Buchanan Retiring committer: Adam Kallai Retiring committer: Zsolt Borbely Retiring committer: Peter Molnar Retiring committer: Krzysztof Kowalczyk Retiring committer: Alok Priyadarshi Retiring committer: Mahesh Kulkarni Retiring committer: Daniel Cheng Retiring committer: Kihong Kwon Retiring committer: Nima Ghanavatian Retiring committer: Thiago Marcos P. Santos Retiring committer: Shawn Singh Retiring committer: Hyowon Kim Retiring committer: Aaron Colwell Retiring committer: Sadrul Habib Chowdhury Retiring committer: Naoki Takano Retiring committer: Cosmin Truta Retiring committer: Alexander Færøy Retiring committer: Chris Guillory Retiring committer: Matt Lilek Retiring committer: Andres Gomez Retiring committer: Ian Vollick Retiring committer: Janos Badics Retiring committer: Justin Novosad Retiring committer: Michael Nordman Inactive committer reviewed, considered active: Zoltan Herczeg Retiring committer: Erik Arvidsson Retiring committer: Luciano Wolf Retiring committer: John Abd-El-Malek Retiring committer: Pam Greene Retiring committer: David Smith Retiring committer: Ilya Sherman Retiring committer: David Grogan Retiring committer: Amruth Raj Retiring committer: William Siegrist Retiring committer: Dan Winship Retiring committer: Mark Pilgrim Retiring committer: Mike Thole Retiring committer: Joshua Bell Retiring committer: Marcus Voltis Bulach Retiring committer: Samuel White Retiring committer: John Knottenbelt Retiring committer: Dmitry Gorbik Retiring committer: Julie Parent Retiring committer: Roland Steiner Retiring committer: Takashi Sakamoto Retiring committer: Jay Civelli Retiring committer: Thiago de Barros Lacerda Retiring committer: Mike Lawther Retiring committer: Evan Stade Retiring committer: Terry Anderson Retiring committer: Cris Neckar Retiring committer: Roland Takacs Retiring committer: Diego Pino Garcia Retiring committer: Evan Martin Retiring committer: Jens Alfke Retiring committer: Seokju Kwon Retiring committer: Carol Szabo Retiring committer: Dinu Jacob Retiring committer: Gabor Rapcsanyi Retiring committer: Vineet Chaudhary Retiring committer: Kangil Han Retiring committer: Graham Dennis Retiring committer: Jason Liu Retiring committer: Elliot Poger Retiring committer: Jakob Petsovits Retiring committer: Hans Wennborg Retiring committer: Rafael Brandao Retiring committer: Rafael Weinstein Retiring committer: Pravin D Retiring committer: Noel Gordon Retiring committer: Dave Barton Retiring committer: Bruno de Oliveira Abinader Retiring committer: Szilard Ledan-Muntean Retiring committer: Dominic Cooney Retiring committer: Andrzej Badowski Retiring committer: Rik Cabanier Retiring committer: Jacky Jiang Retiring committer: Vivek Galatage Retiring committer: Ilya Tikhonovsky Retiring committer: Jenn Braithwaite Retiring committer: Shivakumar J M Retiring committer: Kristof Kosztyo Retiring committer: Kinuko Yasuda Retiring committer: Antoine Labour Retiring committer: Raymond Toy Retiring committer: Fady Samuel Retiring committer: Takashi Toyoshima Retiring committer: Alec Flett Retiring committer: Roger Fong Retiring committer: Jarred Nicholls Retiring committer: Balazs Kelemen Retiring committer: Li Yin Retiring committer: Diego Gonzalez Retiring committer: Gurpreet Kaur Retiring committer: Feng Qian Retiring committer: László Langó Retiring committer: Bill Budge Retiring committer: Martin Hock Retiring committer: Ivan Ivan Krstić Inactive committer reviewed, considered active: Stephanie Lewis Retiring committer: Anton D'Auria Retiring committer: Jeffrey Pfau Retiring committer: Yuzo Fujishima Retiring committer: Matt Perry Retiring committer: Yuqiang Xian Retiring committer: Sergio Correia Retiring committer: Jeremy Moskovich Retiring committer: Jake Nielsen Retiring committer: Radu Stavila Retiring committer: Gregg Tavares Retiring committer: Dmitry Lomov Retiring committer: Kenichi Ishibashi Retiring committer: Zoltan Arvai Retiring committer: Tommy Widenflycht Retiring committer: Lucas De Marchi Retiring committer: Albert J. Wong Retiring committer: Victor Carbune Retiring committer: Ben Murdoch Retiring committer: Charles Wei Retiring committer: Michael Pruett Retiring committer: Dave Tharp Retiring committer: Jakub Wieczorek Retiring committer: Nadav Rotem Retiring committer: Alexander Kellett Retiring committer: Matthew Mirman Retiring committer: Kalyan Kondapally Retiring committer: Pablo Flouret Retiring committer: Mike Reed Retiring committer: Patrick Gansterer Retiring committer: Sudarsana Nagineni Retiring committer: Matt Falkenhagen Retiring committer: Yaar Schnitman Retiring committer: Andy Wingo Retiring committer: Jinwoo Song Retiring committer: Anna Cavender Retiring committer: Steve Lacey Retiring committer: Kimmo Kinnunen Retiring committer: Mike Fenton Retiring committer: Michał Pakuła vel Rutka Retiring committer: Andras Becsi Retiring committer: Justin Schuh Retiring committer: Chris Evans Retiring committer: Eva Balazsfalvi Retiring committer: Dhi Aurrahman Retiring committer: Matt Delaney Retiring committer: Mike Belshe Retiring committer: Cameron McCormack Retiring committer: Andrey Adaykin Retiring committer: Hironori Bono Retiring committer: Vangelis Kokkevis Retiring committer: Yi Shen Retiring committer: John Gregg Retiring committer: Nayan Kumar K Retiring committer: Hans Muller Retiring committer: Greg Bolsinga Retiring committer: Basile Clement Retiring committer: Anton Obzhirov Retiring committer: Keishi Hattori Retiring committer: Arvid Nilsson Retiring committer: Trey Matteson Retiring committer: Joe Thomas Retiring committer: Brian Holt Retiring committer: Raphael Kubo da Costa Retiring committer: Robert Kroeger Retiring committer: Xingnan Wang Retiring committer: Scott Violet Retiring committer: Xiaohai Wei Retiring committer: Joost de Valk Retiring committer: Andrew Lo Retiring committer: Peter Beverloo Retiring committer: Robert Hogan Retiring committer: Siddharth Mathur Retiring committer: Konrad Piascik Retiring committer: Jono Wells Retiring committer: James Kozianski Retiring committer: Ravi Kasibhatla Retiring committer: Laszlo Vidacs Retiring committer: Jungshik Shin Retiring committer: Benjamin Otte Retiring committer: Andrei Popescu Retiring committer: Sami Kyöstilä Retiring committer: Silvia Pfeiffer Retiring committer: Luke Macpherson Retiring committer: Arpita Bahuguna Retiring committer: James Hawkins Retiring committer: Leo Yang Retiring committer: Pavel Podivilov Retiring committer: James Simonsen Retiring committer: Mihai Maerean Retiring committer: Arno Renevier Retiring committer: Peter Gal Retiring committer: Florin Malita Retiring committer: Qi Zhang Retiring committer: Jonathan Dong Retiring committer: Yael Aharon Retiring committer: Eric Uhrhane Retiring committer: Fumitoshi Ukai Retiring committer: Mike West Retiring committer: Brett Wilson Retiring committer: Peter Kasting Retiring committer: Yoshifumi Inoue Retiring committer: Zhenyao Mo Retiring committer: Vincent Scheib Retiring committer: Victoria Kirst Retiring committer: Renata Hodovan Retiring committer: Max Vujovic Retiring committer: David Farler Retiring committer: W. James MacLean Retiring committer: Leandro Pereira Retiring committer: Hayato Ito Retiring committer: Matt Daiter Retiring committer: Gavin Peters Retiring committer: Benjamin C Meyer Retiring committer: Byungwoo Lee Retiring committer: Johnny Ding Retiring committer: Adam Klein Retiring committer: David Michael Barr

Daniel Bates

Comment 14 2016-10-14 15:53:39 PDT

Comment on attachment 291566 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291566&action=review This patch alternates between using single and double quotes for string literals. We should pick one style and be consistent. > Tools/Scripts/validate-committer-lists:169 > + # FIXME: this function fails to find authors of commit-queue patches. Nit: this => This

Daniel Bates

Comment 15 2018-01-31 23:25:31 PST

What is the status of this bug?

Simon Fraser (smfr)

Comment 16 2018-02-01 10:30:35 PST

Idle. Feel free to take it.

Simon Fraser (smfr)

Comment 17 2018-02-01 10:30:54 PST

Don't recall why I didn't land this.

Note You need to log in before you can comment on or make changes to this bug.