Bug 163289

Summary: Update MediaStream events to stop using legacy [ConstructorTemplate=Event]
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, darin, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-10-11 09:58:35 PDT
Update MediaStream events to stop using legacy [ConstructorTemplate=Event] and use regular constructors instead.
Attachments
Patch (29.35 KB, patch)
2016-10-11 12:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (29.38 KB, patch)
2016-10-11 12:13 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-11 12:06:44 PDT
Created attachment 291284 [details] Patch
Chris Dumez
Comment 2 2016-10-11 12:13:41 PDT
Created attachment 291285 [details] Patch
WebKit Commit Bot
Comment 3 2016-10-11 15:39:46 PDT
Comment on attachment 291285 [details] Patch Rejecting attachment 291285 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 291285, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit e0aba4b..271d758 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 207170 = e0aba4be5d9caf05614a10563870de2bf57a0cf4 r207171 = 271d7582ec61f8a815ab88cec656c8fa7692c535 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/2265297
WebKit Commit Bot
Comment 4 2016-10-11 16:14:25 PDT
Comment on attachment 291285 [details] Patch Clearing flags on attachment: 291285 Committed r207175: <http://trac.webkit.org/changeset/207175>
WebKit Commit Bot
Comment 5 2016-10-11 16:14:30 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 6 2016-10-11 16:15:56 PDT
See, if the commit queue rejects your patch, just cq+ again and it lands :)
Alexey Proskuryakov
Comment 7 2016-10-11 19:25:21 PDT
You'd need a git expert to figure this out :-/
Note You need to log in before you can comment on or make changes to this bug.