Summary: | REGRESSION (r28470): Crash expanding a GMail conversation | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ggaren, mrowe | ||||||||
Priority: | P1 | Keywords: | GoogleBug, InRadar, NeedsReduction, Regression | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.4 | ||||||||||
URL: | http://gmail.com/ | ||||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2007-12-06 07:46:20 PST
Internal builds show that r28396 still works. Internal autospade for Leopard reports: Works: r28469 Fails: r28470 http://trac.webkit.org/projects/webkit/changeset/28470 r28470 was a build-fix only so I don't think it can have introduced this bug on it's own. The most likely candidate is the previous "real" change in r28468. Frame::scriptProxy returns 0 because Frame::settings returns 0. GMail removes the frame executing the script from the document, disconnecting it from its page. That's why Frame::settings returns 0. Created attachment 17755 [details]
Patch
Created attachment 17756 [details]
Patch v2
Now with layout test results.
Created attachment 17757 [details]
Patch v2
Now with layout test results.
Committed revision 28496. |