Bug 163279

Summary: MediaResourceLoader should use CachedResource::resourceError to do CORS checks
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2016-10-11 08:27:01 PDT
Currently, MediaResourceLoader is doing the CORS checks itself. We should align MediaResourceLoader with other loaders like ImageLoader.
Attachments
Patch (3.74 KB, patch)
2016-10-11 08:32 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.64 KB, patch)
2016-10-14 01:15 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-10-11 08:32:38 PDT
Created attachment 291261 [details] Patch
Jer Noble
Comment 2 2016-10-12 10:48:55 PDT
Comment on attachment 291261 [details] Patch If this fixes a small bug, how is it covered by existing tests?
youenn fablet
Comment 3 2016-10-12 11:19:16 PDT
(In reply to comment #2) > Comment on attachment 291261 [details] > Patch > > If this fixes a small bug, how is it covered by existing tests? OK, I'll add a test then.
Darin Adler
Comment 4 2016-10-13 12:41:11 PDT
Heh, I had the same thought as Jer, but I didn’t say anything. Oops.
youenn fablet
Comment 5 2016-10-14 01:15:16 PDT
Created attachment 291591 [details] Patch for landing
youenn fablet
Comment 6 2016-10-14 01:18:49 PDT
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 291261 [details] > > Patch > > > > If this fixes a small bug, how is it covered by existing tests? > > OK, I'll add a test then. I was wrong, there was no bug since the crossOrigin value could not be changed once set in MediaResourceLoader. I fixed the change log
WebKit Commit Bot
Comment 7 2016-10-14 02:07:02 PDT
Comment on attachment 291591 [details] Patch for landing Clearing flags on attachment: 291591 Committed r207331: <http://trac.webkit.org/changeset/207331>
WebKit Commit Bot
Comment 8 2016-10-14 02:07:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.