Bug 163277

Summary:

Remove CachedResourceRequest::mutableResourceRequest

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Fixing gtk/efl builds	none
Patch for landing	none

youenn fablet

Reported 2016-10-11 07:14:50 PDT

It should be replaced by releaseResourceRequest and new CachedResourceRequest methods to alter the request. This will allow easier-to-read code within CachedResourceLoader. This will also make more sense if we plan to add CachedResourceRequest::m_isCrossOrigin as envisioned in bug 163103.

Attachments
Patch (39.22 KB, patch) 2016-10-11 07:32 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Fixing gtk/efl builds (39.38 KB, patch) 2016-10-11 08:13 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (38.79 KB, patch) 2016-10-13 03:02 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2016-10-11 07:32:59 PDT

Created attachment 291256 [details] Patch

WebKit Commit Bot

Comment 2 2016-10-11 07:34:58 PDT

Attachment 291256 [details] did not pass style-queue: ERROR: Source/WebCore/loader/cache/CachedResourceRequest.cpp:145: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 3 2016-10-11 08:13:04 PDT

Created attachment 291258 [details] Fixing gtk/efl builds

WebKit Commit Bot

Comment 4 2016-10-11 08:14:52 PDT

Attachment 291258 [details] did not pass style-queue: ERROR: Source/WebCore/loader/cache/CachedResourceRequest.cpp:147: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 5 2016-10-12 11:17:38 PDT

Comment on attachment 291258 [details] Fixing gtk/efl builds Rejecting attachment 291258 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 291258, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: oader/cache/CachedResourceRequest.cpp patching file Source/WebCore/loader/cache/CachedResourceRequest.h patching file Source/WebCore/loader/icon/IconLoader.cpp patching file Source/WebCore/platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp patching file Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2271681

youenn fablet

Comment 6 2016-10-13 03:02:49 PDT

Created attachment 291470 [details] Patch for landing

WebKit Commit Bot

Comment 7 2016-10-13 03:36:52 PDT

Comment on attachment 291470 [details] Patch for landing Clearing flags on attachment: 291470 Committed r207281: <http://trac.webkit.org/changeset/207281>

WebKit Commit Bot

Comment 8 2016-10-13 03:36:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.