Remove CachedResourceRequest::mutableResourceRequest

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

It should be replaced by releaseResourceRequest and new CachedResourceRequest methods to alter the request.
This will allow easier-to-read code within CachedResourceLoader.
This will also make more sense if we plan to add CachedResourceRequest::m_isCrossOrigin as envisioned in bug 163103.

[youenn fablet]

Created attachment 291256 [details]
Patch

[WebKit Commit Bot]

Attachment 291256 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/cache/CachedResourceRequest.cpp:145:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 291258 [details]
Fixing gtk/efl builds

[WebKit Commit Bot]

Attachment 291258 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/cache/CachedResourceRequest.cpp:147:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 291258 [details]
Fixing gtk/efl builds

Rejecting attachment 291258 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 291258, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
oader/cache/CachedResourceRequest.cpp
patching file Source/WebCore/loader/cache/CachedResourceRequest.h
patching file Source/WebCore/loader/icon/IconLoader.cpp
patching file Source/WebCore/platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp
patching file Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2271681

[youenn fablet]

Created attachment 291470 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 291470 [details]
Patch for landing

Clearing flags on attachment: 291470

Committed r207281: <http://trac.webkit.org/changeset/207281>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.