Bug 163214 – Import W3C EME tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

Import W3C EME tests

[Zan Dobersek]

Created attachment 291106 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 291106 [details]
Patch

I would r+ this, but I would like to see the opinion of the test import expert Mr. Fablet.

[youenn fablet]

Comment on attachment 291106 [details]
Patch

Looks good. I would probably remove LayoutTests/imported/w3c/web-platform-tests/encrypted-media/Google if we cannot run the tests.

View in context: https://bugs.webkit.org/attachment.cgi?id=291106&action=review

> LayoutTests/imported/w3c/ChangeLog:10
> +        changes that were introduced while running it.

I regularly refresh all previously imported wpt tests.
If there is an edit in a test that is needed, please make sure this change gets upstreamed in w3c wpt repo.

> LayoutTests/imported/w3c/ChangeLog:16
> +        * web-platform-tests/encrypted-media/: Added. The file list is omitted for clarity.

Seems good to me.
It would be good to update LayoutTests/imported/w3c/resources/ImportExpectations so as to mark web-platform-tests/encrypted-media/ as imported (Comment out the Skip line should suffice).
Otherwise, I'll do it on the next full wpt test resync.

> LayoutTests/imported/w3c/web-platform-tests/encrypted-media/Google/chromium_specific_disabled/encrypted-media-async-creation-with-gc.html:11
> + -->

That seems weird.
It does not harm to import those tests, but I doubt we will able to run them in that form.
It would be best to just not import them.

Ideally we should update LayoutTests/imported/w3c/resources/ImportExpectations to mark these tests as Skip.
If all LayoutTests/imported/w3c/web-platform-tests/encrypted-media/Google tests are like this, we should skip that directory by adding web-platform-tests/encrypted-media/Google [ Skip ] in ImportExpectations.

[Zan Dobersek]

Comment on attachment 291106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291106&action=review

>> LayoutTests/imported/w3c/ChangeLog:10
>> +        changes that were introduced while running it.
> 
> I regularly refresh all previously imported wpt tests.
> If there is an edit in a test that is needed, please make sure this change gets upstreamed in w3c wpt repo.

Understood. There's no changes made to the tests.

>> LayoutTests/imported/w3c/ChangeLog:16
>> +        * web-platform-tests/encrypted-media/: Added. The file list is omitted for clarity.
> 
> Seems good to me.
> It would be good to update LayoutTests/imported/w3c/resources/ImportExpectations so as to mark web-platform-tests/encrypted-media/ as imported (Comment out the Skip line should suffice).
> Otherwise, I'll do it on the next full wpt test resync.

Will do.

>> LayoutTests/imported/w3c/web-platform-tests/encrypted-media/Google/chromium_specific_disabled/encrypted-media-async-creation-with-gc.html:11
>> + -->
> 
> That seems weird.
> It does not harm to import those tests, but I doubt we will able to run them in that form.
> It would be best to just not import them.
> 
> Ideally we should update LayoutTests/imported/w3c/resources/ImportExpectations to mark these tests as Skip.
> If all LayoutTests/imported/w3c/web-platform-tests/encrypted-media/Google tests are like this, we should skip that directory by adding web-platform-tests/encrypted-media/Google [ Skip ] in ImportExpectations.

Will not import these tests and will mark them as skipped.

[Zan Dobersek]

(In reply to comment #4)
> Comment on attachment 291106 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291106&action=review
> 
> >> LayoutTests/imported/w3c/ChangeLog:10
> >> +        changes that were introduced while running it.
> > 
> > I regularly refresh all previously imported wpt tests.
> > If there is an edit in a test that is needed, please make sure this change gets upstreamed in w3c wpt repo.
> 
> Understood. There's no changes made to the tests.
> 

Initially I did have to make some changes because of the link conversions, but after adjusting the flags being passed to the import-w3c-tests script, no change is required anymore.

[Zan Dobersek]

Created attachment 292176 [details]
Patch for landing

[Zan Dobersek]

Committed r207660: <http://trac.webkit.org/changeset/207660>