Summary: | Support InputEvent.dataTransfer for the InputEvent spec | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||||||||||
Component: | UI Events | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, enrica, mcatanzaro, rniwa, webkit-bug-importer | ||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||||||
Bug Blocks: | 163112, 163948 | ||||||||||||||||||||||||
Attachments: |
|
Description
Wenson Hsieh
2016-10-10 07:41:52 PDT
Created attachment 292567 [details]
Patch
Comment on attachment 292567 [details] Patch Attachment 292567 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2354019 New failing tests: fast/events/input-events-fired-when-typing.html editing/pasteboard/paste-head-contents.html Created attachment 292570 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 292582 [details]
Test patch
Created attachment 292608 [details]
Test patch
Created attachment 292612 [details]
Fix EFL/GTK builds.
Created attachment 292613 [details]
Fix EFL/GTK builds.
Created attachment 292617 [details]
Attempt to fix EFL/GTK builds
Created attachment 292622 [details]
Add ChangeLog entries.
Comment on attachment 292622 [details]
Add ChangeLog entries.
It looks like GTK+ is complaining that it can't find the symbol for Pasteboard::Pasteboard.
Please fix that before landing it.
Created attachment 292794 [details]
Attempt to fix GTK build
Created attachment 292798 [details]
Patch for landing
Comment on attachment 292798 [details] Patch for landing Clearing flags on attachment: 292798 Committed r207841: <http://trac.webkit.org/changeset/207841> The test is failing on the GTK+ bot: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/events/input-events-paste-rich-datatransfer-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/events/input-events-paste-rich-datatransfer-actual.txt @@ -2,7 +2,7 @@ destination after pasting (text/html): | <b> -| style="color: rgb(255, 0, 0); font-family: -webkit-standard; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" +| style="color: rgb(255, 0, 0); font-family: -webkit-standard; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px;" | "LayoutTests" | <i> | "are" That difference is that we have -webkit-tap-highlight-color and not -webkit-text-size-adjust. Is it safe to make that the expected result for GTK+, or is it a real bug? It seems safe to mark as expected. The key behavior is that the dataTransfer's text/html data contains the HTML styles of the copied text, which might be different for GTK. Will-do, thanks! (Landed in r207904.) |