Bug 163213

Summary: Support InputEvent.dataTransfer for the InputEvent spec
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: UI EventsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, enrica, mcatanzaro, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 163112, 163948    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Test patch
none
Test patch
none
Fix EFL/GTK builds.
none
Fix EFL/GTK builds.
none
Attempt to fix EFL/GTK builds
none
Add ChangeLog entries.
rniwa: review+
Attempt to fix GTK build
none
Patch for landing none

Description Wenson Hsieh 2016-10-10 07:41:52 PDT
Support InputEvent.dataTransfer for the InputEvent spec
Comment 1 Wenson Hsieh 2016-10-10 13:26:05 PDT
<rdar://problem/28700407>
Comment 2 Wenson Hsieh 2016-10-23 17:32:57 PDT
Created attachment 292567 [details]
Patch
Comment 3 Build Bot 2016-10-23 18:35:17 PDT
Comment on attachment 292567 [details]
Patch

Attachment 292567 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2354019

New failing tests:
fast/events/input-events-fired-when-typing.html
editing/pasteboard/paste-head-contents.html
Comment 4 Build Bot 2016-10-23 18:35:20 PDT
Created attachment 292570 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 5 Wenson Hsieh 2016-10-23 22:46:28 PDT
Created attachment 292582 [details]
Test patch
Comment 6 Wenson Hsieh 2016-10-24 07:36:59 PDT
Created attachment 292608 [details]
Test patch
Comment 7 Wenson Hsieh 2016-10-24 08:10:15 PDT
Created attachment 292612 [details]
Fix EFL/GTK builds.
Comment 8 Wenson Hsieh 2016-10-24 08:26:00 PDT
Created attachment 292613 [details]
Fix EFL/GTK builds.
Comment 9 Wenson Hsieh 2016-10-24 09:26:54 PDT
Created attachment 292617 [details]
Attempt to fix EFL/GTK builds
Comment 10 Wenson Hsieh 2016-10-24 10:26:16 PDT
Created attachment 292622 [details]
Add ChangeLog entries.
Comment 11 Ryosuke Niwa 2016-10-25 11:43:15 PDT
Comment on attachment 292622 [details]
Add ChangeLog entries.

It looks like GTK+ is complaining that it can't find the symbol for Pasteboard::Pasteboard.

Please fix that before landing it.
Comment 12 Wenson Hsieh 2016-10-25 11:56:57 PDT
Created attachment 292794 [details]
Attempt to fix GTK build
Comment 13 Wenson Hsieh 2016-10-25 12:04:36 PDT
Created attachment 292798 [details]
Patch for landing
Comment 14 WebKit Commit Bot 2016-10-25 13:26:01 PDT
Comment on attachment 292798 [details]
Patch for landing

Clearing flags on attachment: 292798

Committed r207841: <http://trac.webkit.org/changeset/207841>
Comment 15 Michael Catanzaro 2016-10-25 17:03:07 PDT
The test is failing on the GTK+ bot:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/events/input-events-paste-rich-datatransfer-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/events/input-events-paste-rich-datatransfer-actual.txt
@@ -2,7 +2,7 @@
 
 destination after pasting (text/html):
 | <b>
-|   style="color: rgb(255, 0, 0); font-family: -webkit-standard; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"
+|   style="color: rgb(255, 0, 0); font-family: -webkit-standard; font-style: normal; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px;"
 |   "LayoutTests"
 |   <i>
 |     "are"

That difference is that we have -webkit-tap-highlight-color and not -webkit-text-size-adjust. Is it safe to make that the expected result for GTK+, or is it a real bug?
Comment 16 Wenson Hsieh 2016-10-25 17:07:01 PDT
It seems safe to mark as expected. The key behavior is that the dataTransfer's text/html data contains the HTML styles of the copied text, which might be different for GTK.
Comment 17 Michael Catanzaro 2016-10-26 10:31:22 PDT
Will-do, thanks!
Comment 18 Michael Catanzaro 2016-10-26 11:30:26 PDT
(Landed in r207904.)