| Summary: | Move Fetch from legacy to new DOM exceptions | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||||||
| Component: | Bindings | Assignee: | Darin Adler <darin> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | achristensen, bfulgham, buildbot, cdumez, cgarcia, commit-queue, esprehn+autocc, gyuyoung.kim, Hironori.Fujii, kondapallykalyan, pvollan, rniwa | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Darin Adler
2016-10-09 23:14:22 PDT
Created attachment 291064 [details]
Patch
Created attachment 291066 [details]
Patch
Comment on attachment 291066 [details] Patch Attachment 291066 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2254101 New failing tests: imported/w3c/web-platform-tests/fetch/api/headers/headers-errors.html imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html Created attachment 291072 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 291066 [details] Patch Attachment 291066 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2254104 New failing tests: imported/w3c/web-platform-tests/fetch/api/headers/headers-errors.html imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html Created attachment 291073 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 291066 [details] Patch Attachment 291066 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2254105 New failing tests: imported/w3c/web-platform-tests/fetch/api/headers/headers-errors.html imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html Created attachment 291074 [details]
Archive of layout-test-results from ews112 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 291066 [details] Patch Attachment 291066 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2254133 New failing tests: imported/w3c/web-platform-tests/fetch/api/headers/headers-errors.html imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html Created attachment 291075 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 291079 [details]
Patch
Can anyone figure out what the Windows failure is? I can’t find any failure in the EWS output. Comment on attachment 291079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291079&action=review > Source/WebCore/Modules/fetch/FetchHeaders.h:89 > + : RefCounted() Not needed? Here's the EWS error:
Thread 2 terminated abnormally: Died at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/generate-bindings-all.pl line 157.
Here's that line in the perl:
system($perl, "$scriptDir/generate-bindings.pl", @args, $file) == 0 or die;
I'm not sure why this is failing.
(In reply to comment #14) > Here's the EWS error: > Thread 2 terminated abnormally: Died at > C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/generate- > bindings-all.pl line 157. > > Here's that line in the perl: > system($perl, "$scriptDir/generate-bindings.pl", @args, > $file) == 0 or die; > > I'm not sure why this is failing. This is using Fujii's new code in Bug 161433. It might be better if we did a "die $!" or something so we could see the specific error. Comment on attachment 291079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291079&action=review >> Source/WebCore/Modules/fetch/FetchHeaders.h:89 >> + : RefCounted() > > Not needed? Build failed on one of the EWS servers without this. Comment on attachment 291079 [details] Patch Rejecting attachment 291079 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 291079, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: file Source/WebCore/Modules/fetch/FetchResponse.idl patching file Source/WebCore/bindings/js/JSDOMBinding.h Hunk #1 succeeded at 948 (offset -1 lines). patching file Source/WebCore/bindings/scripts/CodeGeneratorJS.pm Hunk #1 FAILED at 4925. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorJS.pm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2256506 (In reply to comment #16) > Comment on attachment 291079 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291079&action=review > > >> Source/WebCore/Modules/fetch/FetchHeaders.h:89 > >> + : RefCounted() > > > > Not needed? > > Build failed on one of the EWS servers without this. Gyuyoung, why is the EFL bot building with -Werror=extra ? It is a bit sad to do this kind of things just to make the EFL EWS bot happy. (In reply to comment #18) > (In reply to comment #16) > > Comment on attachment 291079 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=291079&action=review > > > > >> Source/WebCore/Modules/fetch/FetchHeaders.h:89 > > >> + : RefCounted() > > > > > > Not needed? > > > > Build failed on one of the EWS servers without this. > > Gyuyoung, why is the EFL bot building with -Werror=extra ? It is a bit sad > to do this kind of things just to make the EFL EWS bot happy. Gyuyoung ^^ I just backed out the CMake change that seems to be the cause of the EWS failure on Windows. I don't believe there are any other issues with this patch; we should land it and I can help track down any Windows problem that crops up. Based on the EWS error, I believe this was a tooling issue, not a code patch problem. I just applied this patch on Windows and it built successfully locally. I wonder why the commit queue failed to land this. I will land this manually later when I get home. Unless someone else does it for me before that. Committed r207037: <http://trac.webkit.org/changeset/207037> |