Bug 163194

Summary: Move encrypted media from legacy to new DOM exceptions
Product: WebKit Reporter: Darin Adler <darin>
Component: BindingsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch youennf: review+, commit-queue: commit-queue-

Darin Adler
Reported 2016-10-09 22:15:06 PDT
Move encrypted media from legacy to new DOM exceptions
Attachments
Patch (26.09 KB, patch)
2016-10-09 22:23 PDT, Darin Adler 		youennf: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-10-09 22:23:33 PDT
Created attachment 291062 [details] Patch
Darin Adler
Comment 2 2016-10-09 23:25:50 PDT
Darn, looks like really bad timing: https://trac.webkit.org/changeset/206983 renames all these files.
WebKit Commit Bot
Comment 3 2016-10-09 23:34:46 PDT
Comment on attachment 291062 [details] Patch Rejecting attachment 291062 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 291062, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 206981 = 0d236a8285ec8be097a4646de8d66b1ac0342e30 r206982 = cd34d295887f498fb0dd7836e3578e75fcee66e9 r206983 = a8494cf65067b76bc51765c0dcb33c04c77b19a1 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/2253850
Darin Adler
Comment 4 2016-10-09 23:56:55 PDT
Committed r206984: <http://trac.webkit.org/changeset/206984>
youenn fablet
Comment 5 2016-10-10 00:13:28 PDT
As a side note, now that we can easily provide exception error messages, we should probably make that extra effort the default style. We are doing so for binding generated code, which is useful for web developers. WebCore application-level error messages might be even more useful.
Note You need to log in before you can comment on or make changes to this bug.