|Summary:||[GTK] Layout test editing/pasteboard/copy-standalone-image.html failing|
|Product:||WebKit||Reporter:||Michael Catanzaro <mcatanzaro>|
|Component:||WebCore Misc.||Assignee:||Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>|
|Severity:||Normal||CC:||bugs-noreply, cdumez, clopez, commit-queue, mcatanzaro, Ms2ger, sam, webkit-bug-importer|
Description Michael Catanzaro 2016-10-09 13:24:35 PDT
Layout test editing/pasteboard/copy-standalone-image.html is failing since r206965 "[Mac] Write WebArchive to the pasteboard when copying image in WebKit". See https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r206967%20(18701)/editing/pasteboard/copy-standalone-image-diffs.html, it's pasting a URL instead of the actual image. Updating expectations accordingly.
Comment 1 Chris Dumez 2016-10-09 14:05:52 PDT
This is not really a regression from r206965. What I did in r206965 is fix the image copy/paste bug for Mac-WK2 and unskip editing/pasteboard/copy-standalone-image.html for WK2. Given that the test was completely skipped on WK2, you guys did not notice the issue before. I think the right approach is to skip the test again but this time for GTK only until the image copy/paste is fixed for the GTK port.
Comment 2 Michael Catanzaro 2016-10-09 16:36:23 PDT
Oops, I went too quickly and did not notice that the test had been skipped. Removing the REGRESSION tag, but leaving this bug open until the test can be fixed. (It looks to me like a cross-platform test that should eventually be fixed rather than skipped, right?)
Comment 3 Chris Dumez 2016-10-09 16:40:33 PDT
(In reply to comment #2) > Oops, I went too quickly and did not notice that the test had been skipped. > Removing the REGRESSION tag, but leaving this bug open until the test can be > fixed. (It looks to me like a cross-platform test that should eventually be > fixed rather than skipped, right?) Yes, it seems like a proper bug in the GTK's pasteboard implementation if you: - Right click an image in WebKit and select "Copy Image" - Go to an contenteditable field and paste the image Apparently, the GTK port will paste the image's link instead of the image itself, which seems like a bug.
Comment 4 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-08-01 06:24:15 PDT
Created attachment 316849 [details] Patch
Comment 5 WebKit Commit Bot 2017-08-01 09:25:18 PDT
Comment on attachment 316849 [details] Patch Rejecting attachment 316849 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 316849, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 61903e5e760724ab4f9ded6c4c1c5b10890 r220099 = 53205b0d8662ee57a3f758759332896536d81302 r220100 = e11c20b657d8b01a8ce6e2c6ca26947fd2bdf9f2 r220101 = 39d6663e9f1a094325e4e5180d5868226e233f71 r220102 = 39322b2cc90dd7dd7d04cab21bba05bd86efd4d8 r220103 = 5ad8893a4c6ff2b14c40a0019043af0313ab8734 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/4234555
Comment 6 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-08-02 05:05:48 PDT
Created attachment 316954 [details] Patch
Comment 7 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-08-02 05:21:16 PDT
Created attachment 316956 [details] Patch
Comment 8 WebKit Commit Bot 2017-08-02 06:25:39 PDT
Comment on attachment 316956 [details] Patch Clearing flags on attachment: 316956 Committed r220127: <http://trac.webkit.org/changeset/220127>
Comment 9 WebKit Commit Bot 2017-08-02 06:25:41 PDT
All reviewed patches have been landed. Closing bug.