Bug 16318

Summary: Insufficient repaint issues with html embedded in foreignObject
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: bdakin, eric, krit, zimmermann
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
URL: http://starkravingfinkle.org/blog/wp-content/uploads/2007/07/foreignobject-text.svg
Attachments:
Description Flags
Patch
none
Patch
none
Patch mitz: review+

Oliver Hunt
Reported 2007-12-05 20:48:30 PST
If you play around with the selected text in the linked example there are frequent repaint errors
Attachments
Patch (3.15 KB, patch)
2010-01-20 13:06 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (3.20 KB, patch)
2010-01-20 16:26 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (3.07 KB, patch)
2010-01-20 20:45 PST, Oliver Hunt 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2007-12-06 08:18:51 PST
<rdar://problem/5632991>
Eric Seidel (no email)
Comment 2 2007-12-15 03:00:38 PST
I think the way to fix this is to implement a bool RenderSVGBlock::absolutePosition(int& xPos, int& yPos, bool fixed) const function which is absoluteTransform() aware.
Oliver Hunt
Comment 3 2010-01-20 13:06:30 PST
Created attachment 47055 [details] Patch
Eric Seidel (no email)
Comment 4 2010-01-20 13:34:24 PST
Yay! Thanks for fixing.
Oliver Hunt
Comment 5 2010-01-20 13:37:25 PST
Committed r53561: <http://trac.webkit.org/changeset/53561>
Oliver Hunt
Comment 6 2010-01-20 13:38:10 PST
Committed r53561 -- only partial fix, selection for list markers is still borked
Oliver Hunt
Comment 7 2010-01-20 13:50:11 PST
Committed r53562: <http://trac.webkit.org/changeset/53562>
Oliver Hunt
Comment 8 2010-01-20 16:26:27 PST
Created attachment 47076 [details] Patch
Oliver Hunt
Comment 9 2010-01-20 20:45:20 PST
Created attachment 47096 [details] Patch
mitz
Comment 10 2010-01-20 21:00:32 PST
Comment on attachment 47096 [details] Patch > +IntRect RenderListMarker::localSelectionRect() > +{ > + InlineBox* box = inlineBoxWrapper(); > + if (!box) > + return IntRect(); > + RootInlineBox* root = box->root(); > + if (!root) > + return IntRect(); No need to null-check root. > + IntRect localSelectionRect(); You should use this new function in selectionRectForRepaint() too instead of having duplicated code. r=me but please do ^ if possible.
Oliver Hunt
Comment 11 2010-01-20 21:36:51 PST
Committed r53603: <http://trac.webkit.org/changeset/53603>
Note You need to log in before you can comment on or make changes to this bug.