Bug 163177 – Add support for canonicalizing contributors.json, and have check-webkit-style check the format.

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Add support for canonicalizing contributors.json, and have check-webkit-style check the format.

[Simon Fraser (smfr)]

Created attachment 291037 [details]
Patch

[WebKit Commit Bot]

Attachment 291037 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
ERROR: Tools/Scripts/webkitpy/common/config/committers.py:96:  whitespace before ':'  [pep8/E203] [5]
ERROR: Tools/Scripts/webkitpy/common/config/committers.py:166:  whitespace before '}'  [pep8/E202] [5]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

Comment on attachment 291037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291037&action=review

> Tools/Scripts/validate-committer-lists:221
>          committer_cuttof = date.today() - timedelta(days=365)

Typo: cuttof

> Tools/Scripts/validate-committer-lists:235
> +        for  (author, last_commit) in retired_authors_and_last_commits:

Nit: two spaces between for and (

[Ryan Haddad]

webkitpy-test seems to be failing after this change was landed in https://trac.webkit.org/changeset/206967

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/447

[Michael Catanzaro]

Two tests in particular:
                                                                                              [415/1504] webkitpy.layout_tests.run_webkit_tests_integrationtest.RunTest.test_child_processes_2 erred:
  Traceback (most recent call last):
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 230, in test_child_processes_2
      ['--debug-rwt-logging', '--child-processes', '2'], shared_port=False)
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 102, in logging_run
      run_details, output = run_and_capture(port_obj, options, parsed_args, shared_port)
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 113, in run_and_capture
      run_details = run_webkit_tests.run(port_obj, options, parsed_args, logging_stream=logging_stream)
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 439, in run
      run_details = manager.run(args)
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 238, in run
      initial_results, retry_results, enabled_pixel_tests_in_retry = self._run_test_subset(default_device_tests, tests_to_skip)
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 261, in _run_test_subset
      initial_results = self._run_tests(tests_to_run, tests_to_skip, self._options.repeat_each, self._options.iterations, int(self._options.child_processes), retrying=False)
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 322, in _run_tests
      return self._runner.run_tests(self._expectations, test_inputs, tests_to_skip, num_workers, needs_http, needs_websockets, needs_web_platform_test_server, retrying)
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 122, in run_tests
      pool.run(('test_list', shard.name, shard.test_inputs) for shard in all_shards)
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/common/message_pool.py", line 97, in run
      self.wait()
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/common/message_pool.py", line 130, in wait
      self._loop(block=True)
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/common/message_pool.py", line 182, in _loop
      method(message.src, *message.args)
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/common/message_pool.py", line 161, in _handle_worker_exception
      raise WorkerException(str(exception_value))
  WorkerException

and:
                                                                                                       [481/1504] webkitpy.layout_tests.run_webkit_tests_integrationtest.RunTest.test_verbose_in_child_processes failed:
  Traceback (most recent call last):
    File "/home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 830, in test_verbose_in_child_processes
      self.assertTrue('text.html passed' in logging_stream.getvalue())
  AssertionError: False is not true

[Simon Fraser (smfr)]

Investigating.

[Simon Fraser (smfr)]

Landed in
https://trac.webkit.org/changeset/206967
with followup in
https://trac.webkit.org/changeset/206970