Bug 163175

Summary: Air should expose API for pinning registers
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 163171    
Attachments:
Description Flags
this might work
none
more
none
the patch
none
fix win build
keith_miller: review+
Keith's version none

Filip Pizlo
Reported 2016-10-08 20:08:04 PDT
Patch forthcoming.
Attachments
this might work (28.47 KB, patch)
2016-10-08 20:08 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more (33.13 KB, patch)
2016-10-09 11:00 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (40.75 KB, patch)
2016-10-09 12:03 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
fix win build (41.09 KB, patch)
2016-10-10 08:44 PDT, Filip Pizlo 		keith_miller: review+
DetailsFormatted DiffDiff
Keith's version (24.57 KB, patch)
2016-10-10 10:47 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-10-08 20:08:44 PDT
Created attachment 291036 [details] this might work
Filip Pizlo
Comment 2 2016-10-09 11:00:27 PDT
Created attachment 291048 [details] more Not done yet. I think that I still need to fix handleCalleeSaves().
Filip Pizlo
Comment 3 2016-10-09 12:03:13 PDT
Created attachment 291049 [details] the patch
WebKit Commit Bot
Comment 4 2016-10-09 12:07:04 PDT
Attachment 291049 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/air/AirEmitShuffle.cpp:43: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/air/AirEmitShuffle.cpp:52: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/air/AirEmitShuffle.h:105: The parameter name "code" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/b3/air/AirEmitShuffle.h:110: The parameter name "code" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 5 2016-10-10 08:44:26 PDT
Created attachment 291107 [details] fix win build
WebKit Commit Bot
Comment 6 2016-10-10 08:50:50 PDT
Attachment 291107 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/air/AirEmitShuffle.cpp:43: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/air/AirEmitShuffle.cpp:52: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/air/AirEmitShuffle.h:105: The parameter name "code" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/b3/air/AirEmitShuffle.h:110: The parameter name "code" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 7 2016-10-10 09:39:17 PDT
Comment on attachment 291107 [details] fix win build :( I wrote this patch too! This is basically, the same patch that I have, although I have the pinRegister function take the register set rather than calling a pinning method for each one.
Filip Pizlo
Comment 8 2016-10-10 09:44:01 PDT
It looks like the Windows build failure is unrelated - it's dying in generate-bindings, which is far away from what this touches.
Filip Pizlo
Comment 9 2016-10-10 10:15:49 PDT
Landed in http://trac.webkit.org/changeset/207004
Keith Miller
Comment 10 2016-10-10 10:47:25 PDT
Created attachment 291118 [details] Keith's version My version of the patch.
Note You need to log in before you can comment on or make changes to this bug.