Bug 163098

Summary: [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when evicting from PageCache.
Product: WebKit Reporter: Andreas Kling <kling>
Component: FramesAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, koivisto
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for EWS
none
Patch
koivisto: review+, koivisto: commit-queue-
Patch for landing none

Description Andreas Kling 2016-10-06 19:48:32 PDT
<rdar://problem/28663488>
Comment 1 Andreas Kling 2016-10-06 22:25:18 PDT
Created attachment 290895 [details]
Patch for EWS

Needs a proper ChangeLog, but let's test this fix on the EWS.
Comment 2 WebKit Commit Bot 2016-10-06 22:26:24 PDT
Attachment 290895 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:41:  The parameter name "bundle" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:41:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2016-10-07 09:33:17 PDT
Created attachment 290933 [details]
Patch
Comment 4 Antti Koivisto 2016-10-07 09:40:45 PDT
Comment on attachment 290933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290933&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp:91
> +    WKPageLoadURL(webView.page(), adoptWK(Util::createURLForResource("many-iframes", "html")).get());
> +    Util::run(&finished);
> +
> +    // Perform a couple of loads so "simple-iframe" gets kicked out of the PageCache.

There is no "simple-iframe" anywhere. I think you mean "many-iframes".
Comment 5 Antti Koivisto 2016-10-07 09:41:51 PDT
Nice test though!
Comment 6 Andreas Kling 2016-10-07 11:34:21 PDT
Created attachment 290949 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2016-10-07 11:57:40 PDT
Comment on attachment 290949 [details]
Patch for landing

Clearing flags on attachment: 290949

Committed r206922: <http://trac.webkit.org/changeset/206922>
Comment 8 WebKit Commit Bot 2016-10-07 11:57:46 PDT
All reviewed patches have been landed.  Closing bug.