Bug 163085

Summary: Handle non-function, non-undefined comparator in Array.prototype.sort
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Keith Miller
Reported 2016-10-06 14:19:44 PDT
This is broken right now, we should fix it.
Attachments
Patch (3.51 KB, patch)
2016-10-06 14:33 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.29 KB, patch)
2016-10-06 14:53 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.92 KB, patch)
2016-10-12 12:08 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-10-06 14:33:12 PDT
Created attachment 290866 [details] Patch
Yusuke Suzuki
Comment 2 2016-10-06 14:38:12 PDT
Comment on attachment 290866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290866&action=review > Source/JavaScriptCore/builtins/ArrayPrototype.js:650 > else How about just checking here like `else if (comparator !== @undefined)`?
Keith Miller
Comment 3 2016-10-06 14:41:58 PDT
Comment on attachment 290866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290866&action=review >> Source/JavaScriptCore/builtins/ArrayPrototype.js:650 >> else > > How about just checking here like `else if (comparator !== @undefined)`? We need to avoid doing the check if the length of the array is < 2 since that's observably different behavior from other browsers. Although, we could move that check into the main body instead of the helpers. I'll make that change.
Keith Miller
Comment 4 2016-10-06 14:53:21 PDT
Created attachment 290868 [details] Patch for landing
Keith Miller
Comment 5 2016-10-12 12:08:48 PDT
Created attachment 291380 [details] Patch for landing
WebKit Commit Bot
Comment 6 2016-10-12 12:43:29 PDT
Comment on attachment 291380 [details] Patch for landing Clearing flags on attachment: 291380 Committed r207235: <http://trac.webkit.org/changeset/207235>
WebKit Commit Bot
Comment 7 2016-10-12 12:43:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.