Bug 163018 – Import html/webappapis web platform tests

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Chris Dumez]

Import html/webappapis web platform tests to extend test coverage.

[Chris Dumez]

Created attachment 290828 [details]
Patch

[youenn fablet]

Comment on attachment 290828 [details]
Patch

r=me.
Would you be able to fix the link issues?
And for the tests being blocked, maybe it is not worth importing them at the moment?

View in context: https://bugs.webkit.org/attachment.cgi?id=290828&action=review

> LayoutTests/imported/w3c/web-platform-tests/html/webappapis/animation-frames/callback-exception.html:5
> +    <script src="../../../../../../resources/testharness.js"></script>

The links should just be src="../../../../../../resources/testharness.js".
Maybe I miss that on your previous patches.
In your set-up, you might need to use --no-links-conversion option I think.

> LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/inline-event-handler-ordering-expected.txt:4
> +Harness Error (FAIL), message = SyntaxError: Unexpected token '}'

That seems odd.

> LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-expected.txt:1
> +Blocked access to external URL http://www1.localhost:8800/html/webappapis/scripting/processing-model-2/support/syntax-error.js

Might need to fix that test as done previously?

> LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-expected.txt:1
> +Blocked access to external URL http://www1.localhost:8800/html/webappapis/scripting/processing-model-2/support/undefined-variable.js

Ditto.

[Chris Dumez]

Created attachment 290840 [details]
Patch

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 290828 [details]
> Patch
> 
> r=me.
> Would you be able to fix the link issues?
> And for the tests being blocked, maybe it is not worth importing them at the
> moment?
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=290828&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/html/webappapis/animation-frames/callback-exception.html:5
> > +    <script src="../../../../../../resources/testharness.js"></script>
> 
> The links should just be src="../../../../../../resources/testharness.js".
> Maybe I miss that on your previous patches.
> In your set-up, you might need to use --no-links-conversion option I think.

I used to use -l but I did not use it this time because I thought I understood in your previous review that I shouldn't.

> 
> > LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/inline-event-handler-ordering-expected.txt:4
> > +Harness Error (FAIL), message = SyntaxError: Unexpected token '}'
> 
> That seems odd.
> 
> > LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-expected.txt:1
> > +Blocked access to external URL http://www1.localhost:8800/html/webappapis/scripting/processing-model-2/support/syntax-error.js
> 
> Might need to fix that test as done previously?
> 
> > LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-expected.txt:1
> > +Blocked access to external URL http://www1.localhost:8800/html/webappapis/scripting/processing-model-2/support/undefined-variable.js
> 
> Ditto.

[Chris Dumez]

Committed r206874: <http://trac.webkit.org/changeset/206874>

[youenn fablet]

> > The links should just be src="../../../../../../resources/testharness.js".
> > Maybe I miss that on your previous patches.
> > In your set-up, you might need to use --no-links-conversion option I think.
> 
> I used to use -l but I did not use it this time because I thought I
> understood in your previous review that I shouldn't.

Sorry about that misunderstanding.
The -l option is not needed when importing without passing a path to the test source directory but is needed otherwise.

I was about to update https://trac.webkit.org/wiki/WebKitW3CTesting.
But it seems I do not have write access any longer.
When I'll get access, I plan to document your setup which is probably more common than mine.

So you used something like: Tools/Scripts/import-w3c-tests -l /Volumes/Data/w3c -t web-platform-tests/webappapis?

[Chris Dumez]

(In reply to comment #6)
> > > The links should just be src="../../../../../../resources/testharness.js".
> > > Maybe I miss that on your previous patches.
> > > In your set-up, you might need to use --no-links-conversion option I think.
> > 
> > I used to use -l but I did not use it this time because I thought I
> > understood in your previous review that I shouldn't.
> 
> Sorry about that misunderstanding.
> The -l option is not needed when importing without passing a path to the
> test source directory but is needed otherwise.
> 
> I was about to update https://trac.webkit.org/wiki/WebKitW3CTesting.
> But it seems I do not have write access any longer.
> When I'll get access, I plan to document your setup which is probably more
> common than mine.
> 
> So you used something like: Tools/Scripts/import-w3c-tests -l
> /Volumes/Data/w3c -t web-platform-tests/webappapis?

I did:
Tools/Scripts/import-w3c-tests ~/web-platform-tests/html/ -t webappapis -d imported/w3c/web-platform-tests/html/ -l

This mostly worked except that the resources file has wrong relative paths and I had to fix it manually.

FYI, I tried the following but it did not import anything
Tools/Scripts/import-w3c-tests ~/web-platform-tests/html/webappapis -d imported/w3c/web-platform-tests/html/

[youenn fablet]

> I did:
> Tools/Scripts/import-w3c-tests ~/web-platform-tests/html/ -t webappapis -d
> imported/w3c/web-platform-tests/html/ -l
> 
> This mostly worked except that the resources file has wrong relative paths
> and I had to fix it manually.

To fix the relative path, the -d should be set to imported/w3c. Something like that should work.

Tools/Scripts/import-w3c-tests ~ -t web-platform-tests/html/webappapis -d imported/w3c/ -l


> FYI, I tried the following but it did not import anything
> Tools/Scripts/import-w3c-tests ~/web-platform-tests/html/webappapis -d
> imported/w3c/web-platform-tests/html/

When no -t parameter is passed, it expects to import "csswg-test"and "web-platform-tests" sub-directories but there is none in the folder you gave.
The following should import tests and kind-of work:

Tools/Scripts/import-w3c-tests ~/web-platform-tests/html/webappapis -d imported/w3c/web-platform-tests/html/webappapis -l -t .