Bug 162992

Summary: Add a dummy SubtleCrypto interface
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160883    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch bfulgham: review+

Description Jiewen Tan 2016-10-05 18:00:34 PDT
Add a dummy SubtleCrypto interface
Comment 1 Radar WebKit Bug Importer 2016-10-05 18:01:50 PDT
<rdar://problem/28643573>
Comment 2 Jiewen Tan 2016-10-05 18:46:22 PDT
Created attachment 290770 [details]
Patch
Comment 3 Jiewen Tan 2016-10-05 19:03:14 PDT
Created attachment 290772 [details]
Patch
Comment 4 Brent Fulgham 2016-10-05 20:04:42 PDT
Windows build error:

  Generating ../../DerivedSources/WebCore/JSSubtleCrypto.cpp, ../../DerivedSources/WebCore/JSSubtleCrypto.h
  Next token should be }, but empty on line 33:      IDLParser.pm:556 at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 177.
   in /home/buildbot/WebKit/Source/WebCore/crypto/SubtleCrypto.idl at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 177.
  $VAR1 = ' at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 191.
  	IDLParser::assertTokenValue(IDLParser=HASH(0x804f7088), Token=HASH(0x804ee298), "}", 556) called at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 556
  	IDLParser::parseInterface(IDLParser=HASH(0x804f7088), HASH(0x804f7418)) called at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 517
  	IDLParser::parseCallbackOrInterface(IDLParser=HASH(0x804f7088), HASH(0x804f7418)) called at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 483
  	IDLParser::parseDefinition(IDLParser=HASH(0x804f7088), HASH(0x804f7418)) called at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 397
  	IDLParser::parseDefinitions(IDLParser=HASH(0x804f7088)) called at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 245
  	eval {...} called at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 244
  	IDLParser::Parse(IDLParser=HASH(0x804f7088), "/home/buildbot/WebKit/Source/WebCore/crypto/SubtleCrypto.idl", "LANGUAGE_JAVASCRIPT  ENABLE_3D_TRANSFORMS ENABLE_ALLINONE_BUI"..., "\\"C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/a"...) called at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/generate-bindings.pl line 127
  ';
  $VAR1 = ' at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 251.
  	IDLParser::Parse(IDLParser=HASH(0x804f7088), "/home/buildbot/WebKit/Source/WebCore/crypto/SubtleCrypto.idl", "LANGUAGE_JAVASCRIPT  ENABLE_3D_TRANSFORMS ENABLE_ALLINONE_BUI"..., "\\"C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/a"...) called at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/generate-bindings.pl line 127
  ';
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 2. [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCoreDerivedSources.vcxproj]
  Building Custom Rule C:/cygwin/home/buildbot/WebKit/Source/WebKit/CMakeLists.txt
  CMake does not need to re-run because C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKit\CMakeFiles\generate.stamp is up-to-date.
  Generating ../../DerivedSources/WebKit/include/autoversion.h
Comment 5 Alex Christensen 2016-10-06 09:09:38 PDT
Comment on attachment 290772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290772&action=review

> LayoutTests/ChangeLog:16
> +        * crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt-expected.txt: Renamed from LayoutTests/crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt.

why are we moving things to webkitSubtle when we say we are going to deprecate it in comments above?
Comment 6 Jiewen Tan 2016-10-06 11:14:58 PDT
Comment on attachment 290772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290772&action=review

>> LayoutTests/ChangeLog:16
>> +        * crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt-expected.txt: Renamed from LayoutTests/crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt.
> 
> why are we moving things to webkitSubtle when we say we are going to deprecate it in comments above?

We will not deprecate it immediately. Therefore, it is better to keep testing the old interface until we officially deprecate it.
Comment 7 Jiewen Tan 2016-10-06 11:17:25 PDT
Created attachment 290834 [details]
Patch
Comment 8 Jiewen Tan 2016-10-06 11:50:05 PDT
Created attachment 290842 [details]
Patch
Comment 9 Jiewen Tan 2016-10-06 13:04:03 PDT
Created attachment 290855 [details]
Patch
Comment 10 Brent Fulgham 2016-10-06 14:12:18 PDT
Comment on attachment 290855 [details]
Patch

Thank you for fixing the build failure! Looks good. r=me.
Comment 11 Jiewen Tan 2016-10-06 14:17:57 PDT
(In reply to comment #10)
> Comment on attachment 290855 [details]
> Patch
> 
> Thank you for fixing the build failure! Looks good. r=me.

Thanks, Brent.
Comment 12 Jiewen Tan 2016-10-06 14:34:42 PDT
Committed r206883: <http://trac.webkit.org/changeset/206883>