|Summary:||Add a config.h file to DRT|
|Product:||WebKit||Reporter:||Sam Weinig <sam>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Version:||528+ (Nightly build)|
Description Sam Weinig 2007-12-04 16:25:36 PST
Now that DumpRenderTree is starting to be used on multiple platforms, it would be a good idea to add a config.h file to ensure platform specific concepts are included everywhere needed.
Comment 1 Alp Toker 2008-10-11 18:21:50 PDT
Created attachment 24295 [details] Add a config.h file This adds config.h to DumpRenderTree. I've updated the GTK and WIN DRT tools to use the new config.h. Things that still need to be done (and that I don't have the tools to do): * Update the Mac port files * Add config.h to vsproj/xcodeproj files. When adding support for your platform, make sure that the correct config.h is being included in your DRT tool's sources! When config.h has been added to all platforms, this can be removed from DumpRenderTree.h: // FIXME: Remove this when all platforms are using config.h #ifndef Config_H #include <wtf/Platform.h> #endif
Comment 2 Darin Adler 2008-10-14 11:44:08 PDT
Comment on attachment 24295 [details] Add a config.h file Landed as http://trac.webkit.org/changeset/37587. Clearing review flag.
Comment 3 Darin Adler 2008-10-14 11:44:36 PDT
Sam, do you want to take it from here? Or should we leave this unassigned?